From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Subject: [PATCH 08/15] Input: serio: convert bus code to use drv_groups
Date: Fri, 23 Aug 2013 14:24:34 -0700 [thread overview]
Message-ID: <1377293081-10957-8-git-send-email-gregkh@linuxfoundation.org> (raw)
In-Reply-To: <1377293081-10957-1-git-send-email-gregkh@linuxfoundation.org>
The drv_attrs field of struct bus_type is going away soon, drv_groups
should be used instead. This converts the serio bus code to use the
correct field.
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/input/serio/serio.c | 21 +++++++++++----------
1 file changed, 11 insertions(+), 10 deletions(-)
diff --git a/drivers/input/serio/serio.c b/drivers/input/serio/serio.c
index 25fc5971..2b56855c 100644
--- a/drivers/input/serio/serio.c
+++ b/drivers/input/serio/serio.c
@@ -732,19 +732,20 @@ EXPORT_SYMBOL(serio_unregister_child_port);
* Serio driver operations
*/
-static ssize_t serio_driver_show_description(struct device_driver *drv, char *buf)
+static ssize_t description_show(struct device_driver *drv, char *buf)
{
struct serio_driver *driver = to_serio_driver(drv);
return sprintf(buf, "%s\n", driver->description ? driver->description : "(none)");
}
+static DRIVER_ATTR_RO(description);
-static ssize_t serio_driver_show_bind_mode(struct device_driver *drv, char *buf)
+static ssize_t bind_mode_show(struct device_driver *drv, char *buf)
{
struct serio_driver *serio_drv = to_serio_driver(drv);
return sprintf(buf, "%s\n", serio_drv->manual_bind ? "manual" : "auto");
}
-static ssize_t serio_driver_set_bind_mode(struct device_driver *drv, const char *buf, size_t count)
+static ssize_t bind_mode_store(struct device_driver *drv, const char *buf, size_t count)
{
struct serio_driver *serio_drv = to_serio_driver(drv);
int retval;
@@ -760,14 +761,14 @@ static ssize_t serio_driver_set_bind_mode(struct device_driver *drv, const char
return retval;
}
+static DRIVER_ATTR_RW(bind_mode);
-
-static struct driver_attribute serio_driver_attrs[] = {
- __ATTR(description, S_IRUGO, serio_driver_show_description, NULL),
- __ATTR(bind_mode, S_IWUSR | S_IRUGO,
- serio_driver_show_bind_mode, serio_driver_set_bind_mode),
- __ATTR_NULL
+static struct attribute *serio_driver_attrs[] = {
+ &driver_attr_description.attr,
+ &driver_attr_bind_mode.attr,
+ NULL,
};
+ATTRIBUTE_GROUPS(serio_driver);
static int serio_driver_probe(struct device *dev)
{
@@ -996,7 +997,7 @@ EXPORT_SYMBOL(serio_interrupt);
static struct bus_type serio_bus = {
.name = "serio",
.dev_attrs = serio_device_attrs,
- .drv_attrs = serio_driver_attrs,
+ .drv_groups = serio_driver_groups,
.match = serio_bus_match,
.uevent = serio_uevent,
.probe = serio_driver_probe,
--
1.8.3.rc0.20.gb99dd2e
next prev parent reply other threads:[~2013-08-23 21:27 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-23 21:24 [PATCH 01/15] PCI: convert bus code to use bus_groups Greg Kroah-Hartman
2013-08-23 21:24 ` [PATCH 02/15] rbd: " Greg Kroah-Hartman
2013-08-23 21:24 ` Greg Kroah-Hartman
2013-08-27 12:35 ` Alex Elder
2013-08-28 5:07 ` Greg Kroah-Hartman
2013-08-23 21:24 ` [PATCH 03/15] rapidio: " Greg Kroah-Hartman
2013-08-23 21:24 ` [PATCH 04/15] PPC: ibmebus: " Greg Kroah-Hartman
2013-08-23 21:24 ` [PATCH 05/15] PPC: VIO: " Greg Kroah-Hartman
2013-08-23 21:24 ` [PATCH 06/15] SCSI: fcoe: " Greg Kroah-Hartman
2013-08-23 21:24 ` [PATCH 07/15] Input: gameport: convert bus code to use drv_groups Greg Kroah-Hartman
2013-08-24 23:33 ` Dmitry Torokhov
2013-08-25 21:56 ` Greg Kroah-Hartman
2013-08-23 21:24 ` Greg Kroah-Hartman [this message]
2013-08-24 23:33 ` [PATCH 08/15] Input: serio: " Dmitry Torokhov
2013-08-23 21:24 ` [PATCH 09/15] PCI: " Greg Kroah-Hartman
2013-08-23 21:24 ` [PATCH 10/15] USB: serial: " Greg Kroah-Hartman
2013-08-23 21:24 ` [PATCH 11/15] driver-core: platform: convert bus code to use dev_groups Greg Kroah-Hartman
2013-08-23 21:24 ` [PATCH 12/15] HID: " Greg Kroah-Hartman
2013-08-26 11:42 ` Jiri Kosina
2013-08-26 12:05 ` Greg Kroah-Hartman
2013-08-23 21:24 ` [PATCH 13/15] MEI: " Greg Kroah-Hartman
2013-08-23 21:27 ` Winkler, Tomas
2013-08-23 21:24 ` [PATCH 14/15] pmu_bus: " Greg Kroah-Hartman
2013-08-23 21:24 ` [PATCH 15/15] workqueue: " Greg Kroah-Hartman
2013-08-23 21:28 ` Tejun Heo
2013-08-23 21:34 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1377293081-10957-8-git-send-email-gregkh@linuxfoundation.org \
--to=gregkh@linuxfoundation.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.