All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: bitbake-devel <bitbake-devel@lists.openembedded.org>
Subject: Re: [PATCH] process: Improve exit handling and hangs
Date: Sat, 24 Aug 2013 13:40:38 +0100	[thread overview]
Message-ID: <1377348038.6762.190.camel@ted> (raw)
In-Reply-To: <1377346040.6762.186.camel@ted>

> @@ -203,5 +201,5 @@ class BitBakeServer(BitBakeBaseServer):
>  
>      def establishConnection(self):
>          self.connection = BitBakeProcessServerConnection(self.serverImpl, self.ui_channel, self.event_queue)
> -        signal.signal(signal.SIGTERM, lambda i, s: self.connection.terminate(force=True))
> +        signal.signal(signal.SIGTERM, lambda i, s: self.connection.terminate())
>          return self.connection

FWIW I think this piece of the change *may* make bitbake's handling of
Ctrl+C more robust. I know people have reported problems with that and
the function being called here was full of deadlocks. I'd be interested
in feedback on whether it helps.

Cheers,

Richard



  reply	other threads:[~2013-08-24 12:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-24 12:07 [PATCH] process: Improve exit handling and hangs Richard Purdie
2013-08-24 12:40 ` Richard Purdie [this message]
2013-08-27 20:11 ` Jason Wessel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1377348038.6762.190.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=bitbake-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.