From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1nvfUx-0007bz-Mi for mharc-grub-devel@gnu.org; Mon, 30 May 2022 09:31:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55806) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nvfUt-0007VG-P5 for grub-devel@gnu.org; Mon, 30 May 2022 09:31:51 -0400 Received: from mail.efficios.com ([167.114.26.124]:50076) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nvfUr-00058p-GZ for grub-devel@gnu.org; Mon, 30 May 2022 09:31:51 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.efficios.com (Postfix) with ESMTP id 3A5DE40607E; Mon, 30 May 2022 09:31:47 -0400 (EDT) Received: from mail.efficios.com ([127.0.0.1]) by localhost (mail03.efficios.com [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id dFUR5NUjAVQI; Mon, 30 May 2022 09:31:46 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mail.efficios.com (Postfix) with ESMTP id BAC4E405EE3; Mon, 30 May 2022 09:31:46 -0400 (EDT) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.efficios.com BAC4E405EE3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=default; t=1653917506; bh=zcHvzJEOeHM3Fo1YNmL9jQvPq/73TsCC+SrVQNed2lc=; h=Date:From:To:Message-ID:MIME-Version; b=ieFsVs7slWfpGk/Wt48Yjvfu21BvBSlsYiW84M/IcQxHbQNiWfF8pjblQsnUVmrX9 +EVgRfUNOU8P3zfyXbl1fEYBGz5SS7/GxnQ0QH9MdMh2smbW27i/yhYy1ZvQXJBJ07 Is7KKx/+5Ye/G0P43+wztUY6vtQz0HM5d9R3VSIrHfezL1JdIih1xh+mTDfBIVA6jD EdyYsLB9rRaKaa5xeekuHvGwezzlb5TXkrgjXplFYKsu759+4dD5VuX6CU7LsMAgUo WLr6pbC6neXANmGprZGJIDA0/QAYZ8fXq5Ygxyv1xT2Sx6RUJA4idbV7U40IKBraeI +u/wmv2LjtaaQ== X-Virus-Scanned: amavisd-new at efficios.com Received: from mail.efficios.com ([127.0.0.1]) by localhost (mail03.efficios.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id YpzqoJ_yu8WJ; Mon, 30 May 2022 09:31:46 -0400 (EDT) Received: from mail03.efficios.com (mail03.efficios.com [167.114.26.124]) by mail.efficios.com (Postfix) with ESMTP id AF932405DEC; Mon, 30 May 2022 09:31:46 -0400 (EDT) Date: Mon, 30 May 2022 09:31:46 -0400 (EDT) From: Mathieu Desnoyers To: Robbie Harwood Cc: Michael Chang via Grub-devel , Michael Chang Message-ID: <1377444037.10398.1653917506612.JavaMail.zimbra@efficios.com> In-Reply-To: References: <20220520143741.217690-1-mathieu.desnoyers@efficios.com> <20220520143741.217690-6-mathieu.desnoyers@efficios.com> <20220527060746.GA8033@mazu> Subject: Re: [RFC PATCH v3 5/5] Cleanup: grub-mkconfig_lib: remove unused version comparison functions MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [167.114.26.124] X-Mailer: Zimbra 8.8.15_GA_4272 (ZimbraWebClient - FF100 (Linux)/8.8.15_GA_4257) Thread-Topic: Cleanup: grub-mkconfig_lib: remove unused version comparison functions Thread-Index: uXix3nomXY8/FxMieqZPKi0jVIaEtA== Received-SPF: pass client-ip=167.114.26.124; envelope-from=compudj@efficios.com; helo=mail.efficios.com X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 May 2022 13:31:52 -0000 ----- On May 27, 2022, at 10:56 AM, Robbie Harwood rharwood@redhat.com wrote: > Michael Chang via Grub-devel writes: > >> On Thu, May 26, 2022 at 05:07:11PM -0400, Robbie Harwood wrote: >>> Mathieu Desnoyers writes: >>> >>>> There are no users left of version_find_latest(), version_test_gt(), >>>> and version_test_numeric(). Remove those unused helper >>>> functions. Using those helper functions is what caused the quadratic >>>> sorting performance issues in the first place, so removing them is a >>>> net win. >>>> >>>> Signed-off-by: Mathieu Desnoyers >>> >>> Reviewed-by: Robbie Harwood >> >> Hm. This seems to contradict your proposed patch to use distro specific >> sort by hooking into those functions got removed here. >> >> mkconfig: use distro sorts when available >> https://www.mail-archive.com/grub-devel@gnu.org/msg33357.html >> >> I'd like to know more your comments about this as those hooks might >> still be needed or where to keep distribution's sort ? > > The series does, yes - both can't be applied as-is. I'm fine to rebase > mine, but haven't done it yet. I don't mind adding them back if I need > to. Please be mindful not to add back the quadratic sorting algorithm as you do that. Thanks, Mathieu -- Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com