From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Alexander Graf <agraf@suse.de>
Cc: Alexey Kardashevskiy <aik@ozlabs.ru>,
Paolo Bonzini <pbonzini@redhat.com>,
"qemu-ppc@nongnu.org" <qemu-ppc@nongnu.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH] spapr-vscsi: Adding VSCSI capabilities
Date: Mon, 26 Aug 2013 20:03:44 +1000 [thread overview]
Message-ID: <1377511424.3819.51.camel@pasglop> (raw)
In-Reply-To: <9B59EB2A-3DB8-499F-9C94-7CB03704E429@suse.de>
On Mon, 2013-08-26 at 10:43 +0200, Alexander Graf wrote:
> Do we ever need to preserve random fields in that struct? Or would it
> be clearer to just set the whole thing to 0 and then go from there?
Yeah sort of, we set/clear bits more/less based on what the guest
put in the first place, it's a bit strange.
> It's definitely a case-by-case decision which way is better, but
> setting all fields by hand gives you potential for missing to set one.
Right. I'll let Nikunj judge here as he looked at that part of the
protocol more than I have.
Cheers,
Ben.
next prev parent reply other threads:[~2013-08-26 10:04 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-23 9:22 [Qemu-devel] [PATCH] spapr-vscsi: Adding VSCSI capabilities Alexey Kardashevskiy
2013-08-25 16:41 ` Alexander Graf
2013-08-25 20:51 ` Benjamin Herrenschmidt
2013-08-26 13:37 ` Paolo Bonzini
2013-08-27 0:45 ` Benjamin Herrenschmidt
2013-08-25 22:10 ` Benjamin Herrenschmidt
2013-08-26 4:32 ` Nikunj A Dadhania
2013-08-26 5:44 ` Alexander Graf
2013-08-26 6:22 ` Benjamin Herrenschmidt
2013-08-26 8:43 ` Alexander Graf
2013-08-26 9:08 ` Nikunj A Dadhania
2013-08-26 9:52 ` Alexander Graf
2013-08-26 10:03 ` Benjamin Herrenschmidt [this message]
2013-08-26 10:47 ` Nikunj A Dadhania
2013-08-26 10:58 ` Nikunj A Dadhania
2013-08-26 11:17 ` Alexander Graf
2013-08-26 11:46 ` Nikunj A Dadhania
2013-08-26 11:49 ` Alexander Graf
2013-08-27 5:14 ` Nikunj A Dadhania
2013-08-27 5:43 ` Nikunj A Dadhania
2013-08-27 8:45 ` Alexander Graf
2013-08-27 9:27 ` Nikunj A Dadhania
2013-08-26 6:19 ` Benjamin Herrenschmidt
2013-08-26 9:06 ` Nikunj A Dadhania
2013-08-26 13:42 ` Paolo Bonzini
2013-08-27 5:11 ` Nikunj A Dadhania
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1377511424.3819.51.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=agraf@suse.de \
--cc=aik@ozlabs.ru \
--cc=nikunj@linux.vnet.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.