From: Rob Herring <robherring2@gmail.com>
To: netdev@vger.kernel.org
Cc: Ben Hutchings <bhutchings@solarflare.com>,
Lennert Buytenhek <buytenh@wantstofly.org>,
Rob Herring <rob.herring@calxeda.com>
Subject: [PATCH v3 09/11] net: calxedaxgmac: remove some unused statistic counters
Date: Fri, 30 Aug 2013 16:49:27 -0500 [thread overview]
Message-ID: <1377899369-23252-9-git-send-email-robherring2@gmail.com> (raw)
In-Reply-To: <1377899369-23252-1-git-send-email-robherring2@gmail.com>
From: Rob Herring <rob.herring@calxeda.com>
rx_sa_filter_fail and tx_undeflow events are unused and impossible
to occur based on how the h/w is used. We never filter on source MAC
address and TX store and forward mode prevents underflow events.
Reported-by: Lennert Buytenhek <buytenh@wantstofly.org>
Signed-off-by: Rob Herring <rob.herring@calxeda.com>
---
drivers/net/ethernet/calxeda/xgmac.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/ethernet/calxeda/xgmac.c b/drivers/net/ethernet/calxeda/xgmac.c
index 0cff9e3..04c585c 100644
--- a/drivers/net/ethernet/calxeda/xgmac.c
+++ b/drivers/net/ethernet/calxeda/xgmac.c
@@ -353,11 +353,9 @@ struct xgmac_extra_stats {
/* Receive errors */
unsigned long rx_watchdog;
unsigned long rx_da_filter_fail;
- unsigned long rx_sa_filter_fail;
unsigned long rx_payload_error;
unsigned long rx_ip_header_error;
/* Tx/Rx IRQ errors */
- unsigned long tx_undeflow;
unsigned long tx_process_stopped;
unsigned long rx_buf_unav;
unsigned long rx_process_stopped;
@@ -1581,7 +1579,6 @@ static const struct xgmac_stats xgmac_gstrings_stats[] = {
XGMAC_STAT(rx_payload_error),
XGMAC_STAT(rx_ip_header_error),
XGMAC_STAT(rx_da_filter_fail),
- XGMAC_STAT(rx_sa_filter_fail),
XGMAC_STAT(fatal_bus_error),
XGMAC_HW_STAT(rx_watchdog, XGMAC_MMC_RXWATCHDOG),
XGMAC_HW_STAT(tx_vlan, XGMAC_MMC_TXVLANFRAME),
--
1.8.1.2
next prev parent reply other threads:[~2013-08-30 21:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-30 21:49 [PATCH v3 01/11] net: calxedaxgmac: remove NETIF_F_FRAGLIST setting Rob Herring
2013-08-30 21:49 ` [PATCH v3 02/11] net: calxedaxgmac: read correct field in xgmac_desc_get_buf_len Rob Herring
2013-08-30 21:49 ` [PATCH v3 03/11] net: calxedaxgmac: fix race between xgmac_tx_complete and xgmac_tx_err Rob Herring
2013-08-30 21:49 ` [PATCH v3 04/11] net: calxedaxgmac: fix possible skb free before tx complete Rob Herring
2013-08-30 21:49 ` [PATCH v3 05/11] net: calxedaxgmac: update ring buffer tx_head after barriers Rob Herring
2013-08-30 21:49 ` [PATCH v3 06/11] net: calxedaxgmac: fix race with tx queue stop/wake Rob Herring
2013-08-30 22:57 ` Ben Hutchings
2013-08-30 21:49 ` [PATCH v3 07/11] net: calxedaxgmac: enable interrupts after napi_enable Rob Herring
2013-08-30 21:49 ` [PATCH v3 08/11] net: calxedaxgmac: fix various errors in xgmac_set_rx_mode Rob Herring
2013-08-30 21:49 ` Rob Herring [this message]
2013-08-30 21:49 ` [PATCH v3 10/11] net: calxedaxgmac: fix rx DMA mapping API size mismatches Rob Herring
2013-08-30 21:49 ` [PATCH v3 11/11] net: calxedaxgmac: fix xgmac_xmit DMA mapping error handling Rob Herring
2013-09-04 2:22 ` [PATCH v3 01/11] net: calxedaxgmac: remove NETIF_F_FRAGLIST setting David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1377899369-23252-9-git-send-email-robherring2@gmail.com \
--to=robherring2@gmail.com \
--cc=bhutchings@solarflare.com \
--cc=buytenh@wantstofly.org \
--cc=netdev@vger.kernel.org \
--cc=rob.herring@calxeda.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.