From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261505AbUKSRLO (ORCPT ); Fri, 19 Nov 2004 12:11:14 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261504AbUKSRIy (ORCPT ); Fri, 19 Nov 2004 12:08:54 -0500 Received: from mx1.redhat.com ([66.187.233.31]:42966 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S261491AbUKSRGh (ORCPT ); Fri, 19 Nov 2004 12:06:37 -0500 From: David Howells In-Reply-To: <20041119165616.GX2460@waste.org> References: <20041119165616.GX2460@waste.org> <20041119052936.GE8040@waste.org> <20040401020550.GG3150@beast> <200411081434.iA8EYKn7023613@warthog.cambridge.redhat.com> <13104.1100881603@redhat.com> To: Matt Mackall Cc: torvalds@osdl.org, akpm@osdl.org, davidm@snapgear.com, linux-kernel@vger.kernel.org, uclinux-dev@uclinux.org Subject: Re: [PATCH 17/20] FRV: Better mmap support in uClinux User-Agent: EMH/1.14.1 SEMI/1.14.5 (Awara-Onsen) FLIM/1.14.5 (Demachiyanagi) APEL/10.6 Emacs/21.3 (i386-redhat-linux-gnu) MULE/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.5 - "Awara-Onsen") Content-Type: text/plain; charset=US-ASCII Date: Fri, 19 Nov 2004 17:06:18 +0000 Message-ID: <13783.1100883978@redhat.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org > > Don't forget write() too. If someone does a write, that would have to be > > written over the mapping too. Obviously this is not impossible. > > I don't see such a requirement, but it'd be nice, yes. I think it is a requirement. With normal Linux, if you do a write that crosses a shared mmap it will change the mmapped data. David