Re: [PATCH_V2] HOB: split live into iso and hddimg

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Wed, 2013-09-04 at 17:38 -0700, Saul Wold wrote:
> Also the patch summary does not conform to your style, it should be 
> image*: split live into iso and hddimg for hob
> 
> tells us more that it's the image code, not hob code.
> 
> See additional comment below.
> 
> On 09/04/2013 09:10 AM, Saul Wold wrote:
> > On 09/04/2013 08:57 AM, Valentin Popa wrote:
> >> changes to split live into iso and hddimg without
> >> adding a new image type class.
> >>
> >
> > Will there be corresponding patches for the places that IMAGE_FSTYPES
> > use the "live" type?
> >
> > There may also be some doc's changes that are needed.
> >
> > Sau!
> >
> >> [YOCTO #3197]
> >> ---
> >>   meta/classes/image.bbclass       | 11 ++++++++++-
> >>   meta/classes/image_types.bbclass | 11 +++++++----
> >>   2 files changed, 17 insertions(+), 5 deletions(-)
> >>
> >> diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
> >> index ea59c36..3f76d80 100644
> >> --- a/meta/classes/image.bbclass
> >> +++ b/meta/classes/image.bbclass
> >> @@ -87,7 +87,16 @@ do_rootfs[depends] +=
> >> "makedevs-native:do_populate_sysroot virtual/fakeroot-nati
> >>   do_rootfs[depends] +=
> >> "virtual/update-alternatives-native:do_populate_sysroot
> >> update-rc.d-native:do_populate_sysroot"
> >>   do_rootfs[recrdeptask] += "do_packagedata"
> >>
> >> -IMAGE_TYPE_live = '${@base_contains("IMAGE_FSTYPES", "live", "live",
> >> "empty", d)}'
> >> +NOISO = '${@base_contains("IMAGE_FSTYPES", "iso", "0", "1", d)}'
> >> +NOHDD = '${@base_contains("IMAGE_FSTYPES", "hddimg", "0", "1", d)}'
> >> +
> >> +def build_live(d):
> >> +    if d.getVar('NOISO', True) == "0" or d.getVar('NOHDD', True) == "0":
> >> +        return "live"
> >> +    else:
> >> +        return "empty"
> >> +
> I think RP suggested a way to simplify this code.

Its not clear from this patch but I think NOISO and NOHDD are used as
triggers elsewhere in the code so this is probably reasonable.

Cheers,

Richard