From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Paul Mackerras <paulus@au1.ibm.com>,
Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
James Hogan <james.hogan@imgtec.com>,
"James E.J. Bottomley" <jejb@parisc-linux.org>,
Helge Deller <deller@gmx.de>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
"David S. Miller" <davem@davemloft.net>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [RFC PATCH 0/3] irq: Fix stack overflow due to softirq called on current stack
Date: Fri, 06 Sep 2013 08:18:24 +1000 [thread overview]
Message-ID: <1378419504.4321.194.camel@pasglop> (raw)
In-Reply-To: <1378395204-25342-1-git-send-email-fweisbec@gmail.com>
On Thu, 2013-09-05 at 17:33 +0200, Frederic Weisbecker wrote:
> Hi,
>
> This series is a proposition to fix the crash reported here: http://lkml.kernel.org/r/1378330796.4321.50.camel%40pasglop
> And it has the upside to also consolidate a bit the arch do_softirq overriden implementation.
>
> Only tested in x86-64 for now.
Thanks. I'm off for a few days, Paul can you give that a spin ? My
understanding is that the crash was fairly reproduceable... which makes
me wonder what are the chances to get RH to pick that series up for
RHEL7...
Cheers,
Ben.
> Thanks.
>
> Frederic Weisbecker (3):
> irq: Consolidate do_softirq() arch overriden implementations
> irq: Execute softirq on its own stack on irq exit
> irq: Comment on the use of inline stack for ksoftirq
>
> arch/metag/kernel/irq.c | 56 +++++++++++++++++------------------------
> arch/parisc/kernel/irq.c | 17 +-----------
> arch/powerpc/kernel/irq.c | 17 +-----------
> arch/s390/kernel/irq.c | 52 +++++++++++++++----------------------
> arch/sh/kernel/irq.c | 60 ++++++++++++++++++-------------------------
> arch/sparc/kernel/irq_64.c | 31 +++++++---------------
> arch/x86/kernel/irq_32.c | 34 +++++++++----------------
> arch/x86/kernel/irq_64.c | 18 ++-----------
> include/linux/interrupt.h | 11 ++++++++
> kernel/softirq.c | 10 +++----
> 10 files changed, 112 insertions(+), 194 deletions(-)
>
next prev parent reply other threads:[~2013-09-05 22:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-04 21:39 do_softirq() vs __do_softirq() in irq_exit() and stack overflow Benjamin Herrenschmidt
2013-09-05 0:27 ` Benjamin Herrenschmidt
2013-09-05 13:29 ` Frederic Weisbecker
2013-09-05 15:33 ` [RFC PATCH 0/3] irq: Fix stack overflow due to softirq called on current stack Frederic Weisbecker
2013-09-05 15:33 ` [PATCH 1/3] irq: Consolidate do_softirq() arch overriden implementations Frederic Weisbecker
2013-09-05 15:33 ` [PATCH 2/3] irq: Execute softirq on its own stack on irq exit Frederic Weisbecker
2013-09-05 15:33 ` [PATCH 3/3] irq: Comment on the use of inline stack for ksoftirq Frederic Weisbecker
2013-09-05 22:56 ` Frederic Weisbecker
2013-09-05 22:18 ` Benjamin Herrenschmidt [this message]
2013-09-18 6:51 ` [RFC PATCH 0/3] irq: Fix stack overflow due to softirq called on current stack Paul Mackerras
2013-09-19 15:38 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1378419504.4321.194.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=deller@gmx.de \
--cc=fweisbec@gmail.com \
--cc=heiko.carstens@de.ibm.com \
--cc=hpa@zytor.com \
--cc=james.hogan@imgtec.com \
--cc=jejb@parisc-linux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=paulus@au1.ibm.com \
--cc=peterz@infradead.org \
--cc=schwidefsky@de.ibm.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.