From: Cong Wang <amwang@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, yoshfuji@linux-ipv6.org,
stephen@networkplumber.org
Subject: Re: [RFC Patch net-next] ipv6: do not allow ipv6 module to be removed
Date: Fri, 06 Sep 2013 10:52:51 +0800 [thread overview]
Message-ID: <1378435971.969.6.camel@cr0> (raw)
In-Reply-To: <20130905.140604.2263717213507575570.davem@davemloft.net>
On Thu, 2013-09-05 at 14:06 -0400, David Miller wrote:
> From: Cong Wang <amwang@redhat.com>
> Date: Wed, 4 Sep 2013 17:12:50 +0800
>
> > There was some bug report on ipv6 module removal path before.
> > Also, as Stephen pointed out, after vxlan module gets ipv6 support,
> > the ipv6 stub it used is not safe against this module removal either.
> > So, let's just remove inet6_exit() so that ipv6 module will not be
> > able to be unloaded.
> >
> > Cc: Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>
> > Cc: Stephen Hemminger <stephen@networkplumber.org>
> > Cc: David S. Miller <davem@davemloft.net>
> > Signed-off-by: Cong Wang <amwang@redhat.com>
>
> I think we should make an effort to make ipv6 unloadable. If you
> believe little effort is being put into this now, even less will
> be expended if I apply a patch like this one.
>
> And this patch has a lot of problems, you aren't removing all of
> the functions which will be completely unused.
They are still used in the cleanup path of inet6_init() as well, can't
be removed completely.
Thanks!
next prev parent reply other threads:[~2013-09-06 2:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-04 9:12 [RFC Patch net-next] ipv6: do not allow ipv6 module to be removed Cong Wang
2013-09-05 18:06 ` David Miller
2013-09-06 2:52 ` Cong Wang [this message]
2013-09-06 2:58 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1378435971.969.6.camel@cr0 \
--to=amwang@redhat.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.