From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sudeep Dutt Subject: Re: [PATCH RESEND v3 3/7] Intel MIC Host Driver, card OS state management. Date: Fri, 06 Sep 2013 11:29:17 -0700 Message-ID: <1378492157.107744.54.camel@localhost> References: <669a3a3bbfff577c73d05fb568a810cbbc3d5333.1378423596.git.sudeep.dutt@intel.com> <20130906045858.GD28806@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20130906045858.GD28806@kroah.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Greg Kroah-Hartman Cc: Sudeep Dutt , Peter P Waskiewicz Jr , "Yaozu (Eddie) Dong" , Arnd Bergmann , "Michael S. Tsirkin" , Harshavardhan R Kharche , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Ashutosh Dixit , Rob Landley , Caz Yokoyama , Dasaratharaman Chandramouli List-Id: virtualization@lists.linuxfoundation.org On Thu, 2013-09-05 at 21:58 -0700, Greg Kroah-Hartman wrote: > Again, very minor fixups for later (I can even do them...) > > > +static DEVICE_ATTR(state, S_IRUGO|S_IWUSR, mic_show_state, mic_store_state); > > DEVICE_ATTR_RW() please. > > Same for the other attributes you create in this patch. > Sure, we will incorporate these changes along with your other feedback in patch 1 and post the next revision of this patch series. Thanks for the review! Sudeep Dutt From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751461Ab3IFS3t (ORCPT ); Fri, 6 Sep 2013 14:29:49 -0400 Received: from mga03.intel.com ([143.182.124.21]:51007 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750775Ab3IFS3s (ORCPT ); Fri, 6 Sep 2013 14:29:48 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.90,855,1371106800"; d="scan'208";a="291756349" Subject: Re: [PATCH RESEND v3 3/7] Intel MIC Host Driver, card OS state management. From: Sudeep Dutt To: Greg Kroah-Hartman Cc: Arnd Bergmann , Rusty Russell , "Michael S. Tsirkin" , Rob Landley , linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-doc@vger.kernel.org, Asias He , Nikhil Rao , Ashutosh Dixit , Caz Yokoyama , Dasaratharaman Chandramouli , Harshavardhan R Kharche , "Yaozu (Eddie) Dong" , Peter P Waskiewicz Jr , Sudeep Dutt In-Reply-To: <20130906045858.GD28806@kroah.com> References: <669a3a3bbfff577c73d05fb568a810cbbc3d5333.1378423596.git.sudeep.dutt@intel.com> <20130906045858.GD28806@kroah.com> Content-Type: text/plain; charset="UTF-8" Date: Fri, 06 Sep 2013 11:29:17 -0700 Message-ID: <1378492157.107744.54.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 (2.28.3-30.el6) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2013-09-05 at 21:58 -0700, Greg Kroah-Hartman wrote: > Again, very minor fixups for later (I can even do them...) > > > +static DEVICE_ATTR(state, S_IRUGO|S_IWUSR, mic_show_state, mic_store_state); > > DEVICE_ATTR_RW() please. > > Same for the other attributes you create in this patch. > Sure, we will incorporate these changes along with your other feedback in patch 1 and post the next revision of this patch series. Thanks for the review! Sudeep Dutt