All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bandan Das <bsd@redhat.com>
To: qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Gerd Hoffmann <kraxel@redhat.com>,
	Markus Armbruster <armbru@redhat.com>,
	Jan Kiszka <jan.kiszka@siemens.com>
Subject: [Qemu-devel] [PATCH v3 3/3] audio: remove CONFIG_MIXEMU configure option
Date: Sat,  7 Sep 2013 00:54:00 -0400	[thread overview]
Message-ID: <1378529640-20263-4-git-send-email-bsd@redhat.com> (raw)
In-Reply-To: <1378529640-20263-1-git-send-email-bsd@redhat.com>

Signed-off-by: Bandan Das <bsd@redhat.com>
---
 audio/mixeng.c       |  6 ------
 configure            |  8 --------
 hw/audio/hda-codec.c | 30 ------------------------------
 3 files changed, 44 deletions(-)

diff --git a/audio/mixeng.c b/audio/mixeng.c
index 02a9d9f..0e4976f 100644
--- a/audio/mixeng.c
+++ b/audio/mixeng.c
@@ -348,7 +348,6 @@ void mixeng_clear (struct st_sample *buf, int len)
 
 void mixeng_volume (struct st_sample *buf, int len, struct mixeng_volume *vol)
 {
-#ifdef CONFIG_MIXEMU
     if (vol->mute) {
         mixeng_clear (buf, len);
         return;
@@ -364,9 +363,4 @@ void mixeng_volume (struct st_sample *buf, int len, struct mixeng_volume *vol)
 #endif
         buf += 1;
     }
-#else
-    (void) buf;
-    (void) len;
-    (void) vol;
-#endif
 }
diff --git a/configure b/configure
index 18fa608..a908c5b 100755
--- a/configure
+++ b/configure
@@ -215,7 +215,6 @@ linux_user="no"
 bsd_user="no"
 guest_base="yes"
 uname_release=""
-mixemu="no"
 aix="no"
 blobs="yes"
 pkgversion=""
@@ -855,8 +854,6 @@ for opt do
   ;;
   --enable-fdt) fdt="yes"
   ;;
-  --enable-mixemu) mixemu="yes"
-  ;;
   --disable-linux-aio) linux_aio="no"
   ;;
   --enable-linux-aio) linux_aio="yes"
@@ -1067,7 +1064,6 @@ echo "                           (affects only QEMU, not qemu-img)"
 echo "  --block-drv-ro-whitelist=L"
 echo "                           set block driver read-only whitelist"
 echo "                           (affects only QEMU, not qemu-img)"
-echo "  --enable-mixemu          enable mixer emulation"
 echo "  --disable-xen            disable xen backend driver support"
 echo "  --enable-xen             enable xen backend driver support"
 echo "  --disable-xen-pci-passthrough"
@@ -3554,7 +3550,6 @@ echo "mingw32 support   $mingw32"
 echo "Audio drivers     $audio_drv_list"
 echo "Block whitelist (rw) $block_drv_rw_whitelist"
 echo "Block whitelist (ro) $block_drv_ro_whitelist"
-echo "Mixer emulation   $mixemu"
 echo "VirtFS support    $virtfs"
 echo "VNC support       $vnc"
 if test "$vnc" = "yes" ; then
@@ -3735,9 +3730,6 @@ if test "$audio_win_int" = "yes" ; then
 fi
 echo "CONFIG_BDRV_RW_WHITELIST=$block_drv_rw_whitelist" >> $config_host_mak
 echo "CONFIG_BDRV_RO_WHITELIST=$block_drv_ro_whitelist" >> $config_host_mak
-if test "$mixemu" = "yes" ; then
-  echo "CONFIG_MIXEMU=y" >> $config_host_mak
-fi
 if test "$vnc" = "yes" ; then
   echo "CONFIG_VNC=y" >> $config_host_mak
 fi
diff --git a/hw/audio/hda-codec.c b/hw/audio/hda-codec.c
index 19a8a0e..07a43bf 100644
--- a/hw/audio/hda-codec.c
+++ b/hw/audio/hda-codec.c
@@ -118,11 +118,9 @@ static void hda_codec_parse_fmt(uint32_t format, struct audsettings *as)
 #define QEMU_HDA_AMP_NONE    (0)
 #define QEMU_HDA_AMP_STEPS   0x4a
 
-#ifdef CONFIG_MIXEMU
 #define   PARAM mixemu
 #define   HDA_MIXER
 #include "hda-codec-common.h"
-#endif
 
 #define   PARAM nomixemu
 #include  "hda-codec-common.h"
@@ -594,11 +592,7 @@ static const VMStateDescription vmstate_hda_audio = {
 
 static Property hda_audio_properties[] = {
     DEFINE_PROP_UINT32("debug", HDAAudioState, debug,   0),
-#ifdef CONFIG_MIXEMU
     DEFINE_PROP_BOOL("mixer", HDAAudioState, mixer,  true),
-#else
-    DEFINE_PROP_BOOL("mixer", HDAAudioState, mixer, false),
-#endif
     DEFINE_PROP_END_OF_LIST(),
 };
 
@@ -609,15 +603,7 @@ static int hda_audio_init_output(HDACodecDevice *hda)
     if (!a->mixer) {
         return hda_audio_init(hda, &output_nomixemu);
     } else {
-
-#ifdef CONFIG_MIXEMU
         return hda_audio_init(hda, &output_mixemu);
-#else
-        fprintf(stderr, "ERROR: "
-                "hda-codec : Mixer emulation has not been compiled in!\n");
-        return -1;
-#endif
-
     }
 }
 
@@ -628,15 +614,7 @@ static int hda_audio_init_duplex(HDACodecDevice *hda)
     if (!a->mixer) {
         return hda_audio_init(hda, &duplex_nomixemu);
     } else {
-
-#ifdef CONFIG_MIXEMU
         return hda_audio_init(hda, &duplex_mixemu);
-#else
-        fprintf(stderr, "ERROR: "
-                "hda-codec : Mixer emulation has not been compiled in!\n");
-        return -1;
-#endif
-
     }
 }
 
@@ -647,15 +625,7 @@ static int hda_audio_init_micro(HDACodecDevice *hda)
     if (!a->mixer) {
         return hda_audio_init(hda, &micro_nomixemu);
     } else {
-
-#ifdef CONFIG_MIXEMU
         return hda_audio_init(hda, &micro_mixemu);
-#else
-        fprintf(stderr, "ERROR: "
-                "hda-codec : Mixer emulation has not been compiled in!\n");
-        return -1;
-#endif
-
     }
 }
 
-- 
1.8.1.4

  parent reply	other threads:[~2013-09-07  4:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-07  4:53 [Qemu-devel] [PATCH v3 0/3] Make mixer emulation configurable at runtime Bandan Das
2013-09-07  4:53 ` [Qemu-devel] [PATCH v3 1/3] hda-codec: refactor common definitions into a header file Bandan Das
2013-09-07  4:53 ` [Qemu-devel] [PATCH v3 2/3] hda-codec: make mixemu selectable at runtime Bandan Das
2013-09-07  4:54 ` Bandan Das [this message]
2013-09-09  5:58 ` [Qemu-devel] [PATCH v3 0/3] Make mixer emulation configurable " Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1378529640-20263-4-git-send-email-bsd@redhat.com \
    --to=bsd@redhat.com \
    --cc=armbru@redhat.com \
    --cc=jan.kiszka@siemens.com \
    --cc=kraxel@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.