From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Darren Hart <dvhart@linux.intel.com>
Cc: Peter Kjellerstedt <peter.kjellerstedt@axis.com>,
openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/2] bb-matrix: Clean before, rather than after, building
Date: Tue, 10 Sep 2013 16:37:07 +0100 [thread overview]
Message-ID: <1378827427.3484.165.camel@ted> (raw)
In-Reply-To: <1378827008.19978.103.camel@dvhart-mobl4.amr.corp.intel.com>
On Tue, 2013-09-10 at 08:30 -0700, Darren Hart wrote:
> On Fri, 2013-09-06 at 18:12 +0200, Peter Kjellerstedt wrote:
> > This makes sure the the first build starts from a clean state. Otherwise
> > one could have the first build affected by any leftover state from
> > a previous build.
> >
> > This also leaves a working state behind after the final build.
> >
> > Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
>
> Hi Peter,
>
> Thanks for taking the time to send in a fix!
>
> > ---
> > scripts/contrib/bb-perf/bb-matrix.sh | 12 +++++-------
> > 1 file changed, 5 insertions(+), 7 deletions(-)
> >
> > diff --git a/scripts/contrib/bb-perf/bb-matrix.sh b/scripts/contrib/bb-perf/bb-matrix.sh
> > index 37721fe..1064565 100755
> > --- a/scripts/contrib/bb-perf/bb-matrix.sh
> > +++ b/scripts/contrib/bb-perf/bb-matrix.sh
> > @@ -63,6 +63,10 @@ for BB in $BB_RANGE; do
> > date
> > echo "BB=$BB PM=$PM Logging to $BB_LOG"
> >
> > + echo -n " Preparing the work directory... "
> > + rm -rf pseudodone tmp sstate-cache tmp-eglibc &> /dev/null
> > + echo "done"
> > +
>
> Makes sense to me, although there is one point worth discussing. The
> tmp-eglibc directory could change depending on the DISTRO setting iiuc.
> All of tmp, sstate-cache, and tmp-eglibc could be dealt with using
> cleansstate I believe:
>
> bitbake <target> -c cleansstate
>
> Richard, should we consider using this instead?
Sadly this isn't recursive, it applies to <target> and not any
dependencies of it. I'd be tempted to simplify this to rm tmp* and
depend on a convention of calling them tmp*...
Cheers,
Richard
next prev parent reply other threads:[~2013-09-10 15:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-06 16:12 [PATCH 0/2] Fixes for bb-matrix Peter Kjellerstedt
2013-09-06 16:12 ` [PATCH 1/2] bb-matrix: Clean before, rather than after, building Peter Kjellerstedt
2013-09-10 15:30 ` Darren Hart
2013-09-10 15:37 ` Richard Purdie [this message]
2013-09-10 15:40 ` Darren Hart
2013-09-10 15:40 ` Burton, Ross
2013-09-06 16:12 ` [PATCH 2/2] bb-matrix: Make sure local.conf does not interfere Peter Kjellerstedt
2013-09-10 15:33 ` Darren Hart
2013-09-10 15:37 ` Richard Purdie
2013-09-10 15:42 ` Darren Hart
2013-09-10 15:47 ` Richard Purdie
2013-09-11 14:49 ` Peter Kjellerstedt
2013-09-11 16:17 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1378827427.3484.165.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=dvhart@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=peter.kjellerstedt@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.