From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v2 0/6] some libxc cleanups and xen-mfndump Date: Wed, 11 Sep 2013 10:09:22 +0200 Message-ID: <1378886962.2821.98.camel@Solace> References: <20130910174758.7735.13358.stgit@hit-nxdomain.opendns.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8563629274632863923==" Return-path: In-Reply-To: <20130910174758.7735.13358.stgit@hit-nxdomain.opendns.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xen.org Cc: Ian Jackson , Andrew Cooper , Wei Liu , Ian Campbell , Tim Deegan List-Id: xen-devel@lists.xenproject.org --===============8563629274632863923== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-6qtcdjdgZePf7jq0rKR9" --=-6qtcdjdgZePf7jq0rKR9 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable [Amending the Cc-list, since I seem to have managed in including people that shouldn't be bothered by changes like these (Jan, Keir, sorry), as well as missing someone that should instead have been there in the first place (IanJ sorry)] On mar, 2013-09-10 at 19:53 +0200, Dario Faggioli wrote: > Hi everyone, >=20 > This is take 2 of an old submission of mine, doing some basic libxc clean= ups > and introducing a debugging tool I called xen-mfndump. >=20 > Basically, there are a few places in libxc where we issue do_domctl()-s > directly, instead of using the proper xc_xxx() wrapper. This make the cod= e > bigger, redundant, more difficult to understand (e.g., "why xc_xxx() is c= alled > here and is not called there?"), less consistent and less grep-able. The = first > 4 patches of this series address this. >=20 > The last one introduce a little tool I'm using for debugging. It allows o= ne to > see the M2P of the host, the P2M of a domain, some info about the PTEs, a= nd > perform basic searches and comparisons on them. I'm finding it very usefu= l and, > although I do not claim for my situation to be that common, I figured it = could > be nice to have it in the tree, so that is patch 6. Patch 5 is the small > rework/additions necessary to make 6 possible. >=20 > Patches with an '*' next to their name below have been Reviewed-by Andrew > Cooper. >=20 > Thanks and Regards, > Dario >=20 > --- > Dario Faggioli (6): > libxc: introduce xc_domain_get_guest_width() > * libxc: use xc_vcpu_setcontext() instead of calling do_domctl() > libxc: use xc_vcpu_getinfo() instead of calling do_domctl() > * libxc: allow for ctxt to be NULL in xc_vcpu_setcontext > libxc: introduce xc_map_domain_meminfo (and xc_unmap_domain_meminfo= ) > tools/misc: introduce xen-mfndump. >=20 >=20 > tools/libxc/xc_core.c | 20 -- > tools/libxc/xc_cpuid_x86.c | 8 - > tools/libxc/xc_dom_boot.c | 31 +-- > tools/libxc/xc_dom_x86.c | 13 - > tools/libxc/xc_domain.c | 149 +++++++++++++- > tools/libxc/xc_domain_restore.c | 13 - > tools/libxc/xc_offline_page.c | 192 +++--------------- > tools/libxc/xc_pagetab.c | 8 - > tools/libxc/xc_private.c | 8 - > tools/libxc/xc_resume.c | 21 -- > tools/libxc/xenctrl.h | 13 + > tools/libxc/xenguest.h | 17 ++ > tools/libxc/xg_private.h | 9 + > tools/libxc/xg_save_restore.h | 9 - > tools/misc/Makefile | 7 - > tools/misc/xen-mfndump.c | 425 +++++++++++++++++++++++++++++++++= ++++++ > tools/xentrace/xenctx.c | 9 - > 17 files changed, 679 insertions(+), 273 deletions(-) > create mode 100644 tools/misc/xen-mfndump.c >=20 --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-6qtcdjdgZePf7jq0rKR9 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) iEYEABECAAYFAlIwJTIACgkQk4XaBE3IOsTjrwCghVvZnEPzSmnUhGYPhcLVU+Cx eMkAoJRyn3qJhohq5meiG6EVzw/NUCsZ =f4eU -----END PGP SIGNATURE----- --=-6qtcdjdgZePf7jq0rKR9-- --===============8563629274632863923== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============8563629274632863923==--