From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Backport request: 5d98adc3e5e85 (tools/gdbsx: fix build failure with glibc-2.17) to 4.2.x Date: Fri, 13 Sep 2013 11:13:14 +0200 Message-ID: <1379063594.6095.14.camel@Solace> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7473330201352036819==" Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xen.org Cc: Olaf Hering , Ian Jackson , Jan Beulich List-Id: xen-devel@lists.xenproject.org --===============7473330201352036819== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-jS1OnbjsFLhO2GfYM6w/" --=-jS1OnbjsFLhO2GfYM6w/ Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, Here on my box (Debian with libc version 2.17-92+b1) building the tools for 4.2.3 is broken as follows: gcc -O1 -fno-omit-frame-pointer -m64 -g -fno-strict-aliasing -std=3Dgnu99 = -Wall -Wstrict-prototypes -Wdeclaration-after-statement -Wno-unused-but-set= -variable -Wno-unused-local-typedefs -D__XEN_TOOLS__ -MMD -MF .xg_main.o.= d -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -fno-optimize-sibling-calls -= Werror -Wmissing-prototypes -I/home/dario/Sources/xen/xen/xen-4.2.3/tools/= debugger/gdbsx/xg/../../../../tools/include -c -o xg_main.o xg_main.c=20 xg_main.c: In function =E2=80=98_domctl_hcall=E2=80=99: xg_main.c:181:52: error: =E2=80=98ulong=E2=80=99 undeclared (first use in t= his function) rc =3D ioctl(_dom0_fd, IOCTL_PRIVCMD_HYPERCALL, (ulong)&hypercall); ^ xg_main.c:181:52: note: each undeclared identifier is reported only once fo= r each function it appears in xg_main.c: In function =E2=80=98_check_hyp=E2=80=99: xg_main.c:221:52: error: =E2=80=98ulong=E2=80=99 undeclared (first use in t= his function) rc =3D ioctl(_dom0_fd, IOCTL_PRIVCMD_HYPERCALL, (ulong)&hypercall); ^ make[4]: *** [xg_main.o] Error 1 make[4]: Leaving directory `/home/dario/Sources/xen/xen/xen-4.2.3/tools/deb= ugger/gdbsx/xg' make[3]: *** [all] Error 2 make[3]: Leaving directory `/home/dario/Sources/xen/xen/xen-4.2.3/tools/deb= ugger/gdbsx' make[2]: *** [subdir-install-debugger/gdbsx] Error 2 make[2]: Leaving directory `/home/dario/Sources/xen/xen/xen-4.2.3/tools' make[1]: *** [subdirs-install] Error 2 make[1]: Leaving directory `/home/dario/Sources/xen/xen/xen-4.2.3/tools' make: *** [install-tools] Error 2 Just cherry picking 5d98adc3e5e859ba23f62ca63450f6a60a9c5e2f fixed the issue, which makes perfect sense, as that change does "tools/gdbsx: fix build failure with glibc-2.17". I therefore think it should be backported... Should I send a proper patch against RELEASE-4.2.3 myself? Of course I can, just asking because cherry-pick seems to work already, so I'm not sure what would be better. Just let me know. Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-jS1OnbjsFLhO2GfYM6w/ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) iEYEABECAAYFAlIy1yoACgkQk4XaBE3IOsRqXQCgjNBescse8J62Otvs15T0qgNU FdEAn1m28AFPDcVd3JB8aCKX+WoZXzvj =hXfR -----END PGP SIGNATURE----- --=-jS1OnbjsFLhO2GfYM6w/-- --===============7473330201352036819== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============7473330201352036819==--