From: "Hervé Poussineau" <hpoussin@reactos.org>
To: qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Hervé Poussineau" <hpoussin@reactos.org>,
"Paul Brook" <paul@codesourcery.com>
Subject: [Qemu-devel] [PATCH 2/4] lsi: check ssid versus sdid only if ssid is valid
Date: Fri, 13 Sep 2013 21:50:55 +0200 [thread overview]
Message-ID: <1379101857-27500-3-git-send-email-hpoussin@reactos.org> (raw)
In-Reply-To: <1379101857-27500-1-git-send-email-hpoussin@reactos.org>
This prevents some (invalid) error messages on console.
Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
---
hw/scsi/lsi53c895a.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/scsi/lsi53c895a.c b/hw/scsi/lsi53c895a.c
index ca01e86..764feaa 100644
--- a/hw/scsi/lsi53c895a.c
+++ b/hw/scsi/lsi53c895a.c
@@ -1705,8 +1705,9 @@ static void lsi_reg_writeb(LSIState *s, int offset, uint8_t val)
s->sxfer = val;
break;
case 0x06: /* SDID */
- if ((val & 0xf) != (s->ssid & 0xf))
+ if ((s->ssid & 0x80) && (val & 0xf) != (s->ssid & 0xf)) {
BADF("Destination ID does not match SSID\n");
+ }
s->sdid = val & 0xf;
break;
case 0x07: /* GPREG0 */
--
1.7.10.4
next prev parent reply other threads:[~2013-09-13 19:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-13 19:50 [Qemu-devel] [PATCH 0/4] lsi: small cleanup and add 53C810 variant Hervé Poussineau
2013-09-13 19:50 ` [Qemu-devel] [PATCH 1/4] lsi: use constant name instead of its value Hervé Poussineau
2013-09-13 19:50 ` Hervé Poussineau [this message]
2013-09-13 19:50 ` [Qemu-devel] [PATCH 3/4] lsi: ignore write accesses to CTEST0 registers Hervé Poussineau
2013-09-13 19:50 ` [Qemu-devel] [PATCH 4/4] lsi: add 53C810 variant Hervé Poussineau
2013-09-14 0:13 ` [Qemu-devel] [PATCH 0/4] lsi: small cleanup and " Peter Maydell
2013-09-14 7:26 ` Paolo Bonzini
2013-09-14 8:05 ` Hervé Poussineau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1379101857-27500-3-git-send-email-hpoussin@reactos.org \
--to=hpoussin@reactos.org \
--cc=paul@codesourcery.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.