All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: imammedo@redhat.com
Subject: [Qemu-devel] [PATCH v2 0/6] pci: keep window properties up to date
Date: Sun, 15 Sep 2013 11:46:36 +0300	[thread overview]
Message-ID: <1379234759-31527-1-git-send-email-mst@redhat.com> (raw)

w32/w64 properties that we report in QOM are
currently static, but this is wrong:
guest firmware can select its own windows:
optimal placement for w64 is guest-dependent, further,
for Q35, w32 is affected by the MCFG base and size.

This detects the actual window configuration used by guest
and reports it in QOM.

Changes from v1:
Fix up issues noted by Igor:
    - ignore addresses below 1<<32 when getting W64
    - don't change W64 - instead calculate it in
      a local variable. This way users are forced
      to use the property API so they won't get
      an out of date range by accessing w64 directly.

Note: maybe we should get rid of the pci_info struct completely, it doesn't
seem to be all that useful anymore.

However, this is better addressed by a separate patch.

Michael S. Tsirkin (6):
  q35: make pci window address/size match guest cfg
  range: add Range to typedefs
  range: add min/max operations on ranges
  pci: add helper to retrieve the 64-bit range
  q35: use 64 bit window programmed by guest
  piix: use 64 bit window programmed by guest

 include/hw/pci/pci.h    |  1 +
 include/qemu/range.h    | 19 ++++++++++++++++++-
 include/qemu/typedefs.h |  1 +
 hw/pci-host/piix.c      | 14 ++++++++++----
 hw/pci-host/q35.c       | 24 ++++++++++++++++++++----
 hw/pci/pci.c            | 50 +++++++++++++++++++++++++++++++++++++++++++++++++
 6 files changed, 100 insertions(+), 9 deletions(-)

-- 
MST

             reply	other threads:[~2013-09-15  8:44 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-15  8:46 Michael S. Tsirkin [this message]
2013-09-15  8:46 ` [Qemu-devel] [PATCH v2 1/6] q35: make pci window address/size match guest cfg Michael S. Tsirkin
2013-09-15  8:46 ` [Qemu-devel] [PATCH v2 2/6] range: add Range to typedefs Michael S. Tsirkin
2013-09-15  8:46 ` [Qemu-devel] [PATCH v2 3/6] range: add min/max operations on ranges Michael S. Tsirkin
2013-09-15  8:49   ` Michael S. Tsirkin
2013-09-15  8:46 ` [Qemu-devel] [PATCH v2 4/6] pci: add helper to retrieve the 64-bit range Michael S. Tsirkin
2013-09-15  8:46 ` [Qemu-devel] [PATCH v2 5/6] q35: use 64 bit window programmed by guest Michael S. Tsirkin
2013-09-15  8:46 ` [Qemu-devel] [PATCH v2 6/6] piix: " Michael S. Tsirkin
2013-09-16 16:17 ` [Qemu-devel] [PATCH v2 0/6] pci: keep window properties up to date Igor Mammedov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1379234759-31527-1-git-send-email-mst@redhat.com \
    --to=mst@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.