From: Dario Faggioli <dario.faggioli@citrix.com>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: George Dunlap <george.dunlap@eu.citrix.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH v2 5/5] xl: test script for the cpumap parser (for vCPU pinning)
Date: Mon, 16 Sep 2013 20:50:54 +0200 [thread overview]
Message-ID: <1379357454.6095.172.camel@Solace> (raw)
In-Reply-To: <1378892977.10928.49.camel@kazak.uk.xensource.com>
[-- Attachment #1.1: Type: text/plain, Size: 1276 bytes --]
On mer, 2013-09-11 at 10:49 +0100, Ian Campbell wrote:
> On Tue, 2013-09-10 at 18:52 +0100, Ian Jackson wrote:
> > Dario Faggioli writes ("[PATCH v2 5/5] xl: test script for the cpumap parser (for vCPU pinning)"):
> > > This commit introduces "check-xl-vcpupin-parse" for helping
> > > verifying and debugging the (v)CPU bitmap parsing code in xl.
> > >
> > > The script runs "xl -N vcpu-pin 0 all <some strings>"
> > > repeatedly, with various input strings, and checks that the
> > > output is as expected.
> [...]
> > I think it would be better, TBH, if you separated out the test
> > generation from the execution. check-xl-vif-parse et al have the test
> > data as an annex to the harness material, but you could have it in a
> > separate file which you could have a script to generate.
>
> Support for testing specific strings which have been reported as buggy
> in the past would be useful too.
>
Done in v3 (just posted) via passing a "-s <string>" option to the
script.
Dario
--
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2013-09-16 18:50 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-06 15:55 [PATCH v2 0/5] xl: allow for node-wise specification of vcpu pinning Dario Faggioli
2013-09-06 15:55 ` [PATCH v2 1/5] xl: update the manpage about "cpus=" and NUMA node-affinity Dario Faggioli
2013-09-06 16:00 ` Ian Jackson
2013-09-06 15:55 ` [PATCH v2 2/5] libxl: introduce libxl_node_to_cpumap Dario Faggioli
2013-09-06 15:59 ` Ian Jackson
2013-09-06 15:55 ` [PATCH v2 3/5] xl: allow for node-wise specification of vcpu pinning Dario Faggioli
2013-09-06 16:37 ` Ian Jackson
2013-09-10 17:42 ` Dario Faggioli
2013-09-06 16:38 ` Ian Jackson
2013-09-10 17:38 ` Dario Faggioli
2013-09-06 15:55 ` [PATCH v2 4/5] xl: implement and enable dryrun mode for `xl vcpu-pin' Dario Faggioli
2013-09-08 22:28 ` Matt Wilson
2013-09-10 17:39 ` Dario Faggioli
2013-09-10 17:49 ` Ian Jackson
2013-09-06 15:56 ` [PATCH v2 5/5] xl: test script for the cpumap parser (for vCPU pinning) Dario Faggioli
2013-09-10 17:52 ` Ian Jackson
2013-09-11 8:31 ` Dario Faggioli
2013-09-11 10:49 ` Ian Jackson
2013-09-16 18:48 ` Dario Faggioli
2013-09-11 9:49 ` Ian Campbell
2013-09-16 18:50 ` Dario Faggioli [this message]
2013-09-06 16:12 ` [PATCH v2 0/5] xl: allow for node-wise specification of vcpu pinning Dario Faggioli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1379357454.6095.172.camel@Solace \
--to=dario.faggioli@citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.