From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH RFC v2 1/7] xen/vNUMA: vNUMA support for PV guests. Date: Tue, 17 Sep 2013 11:04:44 +0200 Message-ID: <1379408684.32441.82.camel@Abyss> References: <1379062190-13720-1-git-send-email-ufimtseva@gmail.com> <52381B4C02000078000F3DD5@nat28.tlf.novell.com> <1379401878.32441.42.camel@Abyss> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7990889497746378507==" Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Elena Ufimtseva Cc: Keir Fraser , Li Yechen , George Dunlap , Matt Wilson , Stefano Stabellini , "xen-devel@lists.xen.org" , Jan Beulich List-Id: xen-devel@lists.xenproject.org --===============7990889497746378507== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-KD7YHYI+H+KnPRuCGRaH" --=-KD7YHYI+H+KnPRuCGRaH Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On mar, 2013-09-17 at 03:19 -0400, Elena Ufimtseva wrote: > On Tue, Sep 17, 2013 at 3:11 AM, Dario Faggioli > wrote: > > On mar, 2013-09-17 at 08:05 +0100, Jan Beulich wrote: > >> But - all this is only for the internal representations. Anything in > >> the public interface should be wide enough to allow future > >> extension. > >> > > And, in fact, 'node_to_node_distance' in xen/include/public/sysctl.h > > (http://xenbits.xen.org/gitweb/?p=3Dxen.git;a=3Dblob;f=3Dxen/include/pu= blic/sysctl.h) > > is uint32. > > >=20 > Linux has u8 for distance. Ok, thank you for pointing that out. >=20 EhEh... So, very hard to be consistent with every actor in the play! :-) Anyway, I think the point here is, as Jan was saying, to distinguish internal representation from interface. Within Xen, we should store everything in the smallest and nicest possible way (which, BTW, is what Linux does by using u8 for distances). OTOH, when it comes to exported interfaces, we should be much more cautious, since changing the way Xen stores distances internally is trivial, changing the interface (either API or ABI) could be a nightmare! In this case, what we (Xen) tell Linux is the interface, it is up to him (Linux) to convert that in a way that suits its own internals. In fact, despite Linux being the only one OS using this interface for now, it's not wise to design the interface itself specifically for Linux, since many OSes may want to support it in the future. Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-KD7YHYI+H+KnPRuCGRaH Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) iEYEABECAAYFAlI4GywACgkQk4XaBE3IOsR6vACfc/23MLQ2XRfgkyV+XsLCNQ+N v1YAn0xIM+PXA3DVugThIN2R4HvAz1pA =wfye -----END PGP SIGNATURE----- --=-KD7YHYI+H+KnPRuCGRaH-- --===============7990889497746378507== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============7990889497746378507==--