Re: [PATCH RFC v2 0/2] linux/vnuma: vNUMA PV guest support introduction

[Dario Faggioli <dario.faggioli@citrix.com>]

[-- Attachment #1.1: Type: text/plain, Size: 2025 bytes --]

On mar, 2013-09-17 at 04:33 -0400, Elena Ufimtseva wrote:
> This patchset introduces vNUMA for PV domU guest.
> 
I'm picky and I know it, but I think domU and guest are synonyms...
Having just one of them should be enough.

Also, the subject line "linux/vnuma: vNUMA...". It is indeed a good
practice to indicate to what component and subsystem the patches applies
to. However, in this case, I don't think havin "linux/" there adds much,
since you'll be sending these mainly in LKML (although, yes, they'll go
on xen-devel too, but I honestly think we can manage).

Regarding the "/vnuma" part, well, vnuma isn't really a subsystem.
Actually, it does not even exist before this series, so again, I won't
put it there.

Actually, from a Linux developer/maintainer point of view, these patches
are about Xen, so something like "xen:..." or "x86/xen:" is probably
better

> Enables PV guest to discover NUMA topology provided by Xen
> and initializes NUMA topology on boot. XENMEM subop hypercall
> is used to retreive information from Xen. 
>
The fact that this happens during the regular x86 NUMA initialization
phase (i.e., in x86_numa_init()) is worth mentioning here.

> Xen provides number 
> of NUMA nodes, memory regions (start and end pfn) constructed 
> based on e820 domU map, distance table and cpu to node map. i
> xen_numa_init is called to setup NUMA related structures. 
> To enable this mechanism, kernel should be compiled as PV guest
> with CONFIG_NUMA=y and Xen should support vNUMA functionality 
> (patchset http://lists.xenproject.org/archives/html/xen-devel/2013-09/msg01337.html ).
>  
This is fine. Perhaps I'd add something about future plans, which are to
extend this to work for Dom0 too.

Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel