From: "Michel Dänzer" <michel@daenzer.net>
To: "Marek Olšák" <maraeo@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] radeon: fix pitch alignment for non-power-of-two mipmaps on SI
Date: Thu, 19 Sep 2013 16:41:00 +0200 [thread overview]
Message-ID: <1379601660.19426.6.camel@thor.local> (raw)
In-Reply-To: <1379594038-17106-1-git-send-email-marek.olsak@amd.com>
On Don, 2013-09-19 at 14:33 +0200, Marek Olšák wrote:
> This fixes VM protection faults.
>
> I have a new piglit test which can iterate over all possible widths, heights,
> and depths (including NPOT) and tests mipmapping with various texture targets.
>
> After this is committed, I'll make a new release of libdrm and bump
> the libdrm version requirement in Mesa.
> ---
> radeon/radeon_surface.c | 14 +++++++++++---
> 1 file changed, 11 insertions(+), 3 deletions(-)
>
> diff --git a/radeon/radeon_surface.c b/radeon/radeon_surface.c
> index 1710e34..d5c45c4 100644
> --- a/radeon/radeon_surface.c
> +++ b/radeon/radeon_surface.c
> @@ -1412,7 +1412,11 @@ static void si_surf_minify(struct radeon_surface *surf,
> uint32_t xalign, uint32_t yalign, uint32_t zalign,
> uint32_t slice_align, unsigned offset)
> {
> - surflevel->npix_x = mip_minify(surf->npix_x, level);
> + if (level == 0) {
> + surflevel->npix_x = surf->npix_x;
> + } else {
> + surflevel->npix_x = mip_minify(next_power_of_two(surf->npix_x), level);
> + }
> surflevel->npix_y = mip_minify(surf->npix_y, level);
> surflevel->npix_z = mip_minify(surf->npix_z, level);
>
Shouldn't this be done (only) for nblk_x instead of npix_x?
--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast | Debian, X and DRI developer
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2013-09-19 14:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-19 12:33 [PATCH] radeon: fix pitch alignment for non-power-of-two mipmaps on SI Marek Olšák
2013-09-19 14:41 ` Michel Dänzer [this message]
2013-09-19 16:37 ` Marek Olšák
2013-09-19 16:41 ` Marek Olšák
2013-09-20 14:14 ` Michel Dänzer
2013-09-20 14:43 ` Marek Olšák
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1379601660.19426.6.camel@thor.local \
--to=michel@daenzer.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=maraeo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.