From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Senna Tschudin Date: Sat, 21 Sep 2013 22:27:36 +0000 Subject: [PATCH 04/19] isdn: Change variable type to bool Message-Id: <1379802471-30252-4-git-send-email-peter.senna@gmail.com> List-Id: References: <1379802471-30252-1-git-send-email-peter.senna@gmail.com> In-Reply-To: <1379802471-30252-1-git-send-email-peter.senna@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: mac@melware.de Cc: isdn4linux@listserv.isdn4linux.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Peter Senna Tschudin The variable noCh is only assigned the values true and false. Change its type to bool. The simplified semantic patch that find this problem is as follows (http://coccinelle.lip6.fr/): @exists@ type T; identifier b; @@ - T + bool b = ...; ... when any b = \(true\|false\) Signed-off-by: Peter Senna Tschudin --- drivers/isdn/hardware/eicon/message.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/isdn/hardware/eicon/message.c b/drivers/isdn/hardware/eicon/message.c index a82e542..05d889a 100644 --- a/drivers/isdn/hardware/eicon/message.c +++ b/drivers/isdn/hardware/eicon/message.c @@ -1207,7 +1207,7 @@ static byte connect_req(dword Id, word Number, DIVA_CAPI_ADAPTER *a, byte m; static byte esc_chi[35] = {0x02, 0x18, 0x01}; static byte lli[2] = {0x01, 0x00}; - byte noCh = 0; + bool noCh = false; word dir = 0; byte *p_chi = ""; -- 1.8.3.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752643Ab3IUW3A (ORCPT ); Sat, 21 Sep 2013 18:29:00 -0400 Received: from mail-wi0-f172.google.com ([209.85.212.172]:54973 "EHLO mail-wi0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752070Ab3IUW2h (ORCPT ); Sat, 21 Sep 2013 18:28:37 -0400 From: Peter Senna Tschudin To: mac@melware.de Cc: isdn4linux@listserv.isdn4linux.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Peter Senna Tschudin Subject: [PATCH 04/19] isdn: Change variable type to bool Date: Sun, 22 Sep 2013 00:27:36 +0200 Message-Id: <1379802471-30252-4-git-send-email-peter.senna@gmail.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1379802471-30252-1-git-send-email-peter.senna@gmail.com> References: <1379802471-30252-1-git-send-email-peter.senna@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The variable noCh is only assigned the values true and false. Change its type to bool. The simplified semantic patch that find this problem is as follows (http://coccinelle.lip6.fr/): @exists@ type T; identifier b; @@ - T + bool b = ...; ... when any b = \(true\|false\) Signed-off-by: Peter Senna Tschudin --- drivers/isdn/hardware/eicon/message.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/isdn/hardware/eicon/message.c b/drivers/isdn/hardware/eicon/message.c index a82e542..05d889a 100644 --- a/drivers/isdn/hardware/eicon/message.c +++ b/drivers/isdn/hardware/eicon/message.c @@ -1207,7 +1207,7 @@ static byte connect_req(dword Id, word Number, DIVA_CAPI_ADAPTER *a, byte m; static byte esc_chi[35] = {0x02, 0x18, 0x01}; static byte lli[2] = {0x01, 0x00}; - byte noCh = 0; + bool noCh = false; word dir = 0; byte *p_chi = ""; -- 1.8.3.1