All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: David Nystrom <david.c.nystrom@gmail.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] shadow: Create recipe nativesdk-shadow
Date: Mon, 23 Sep 2013 22:14:31 +0100	[thread overview]
Message-ID: <1379970871.18603.265.camel@ted> (raw)
In-Reply-To: <CAAKB1h2tRBDowRYZ9vOXduTCy0Fg4aoD+fJmVkN7vZ=XqzWpEg@mail.gmail.com>

On Mon, 2013-09-23 at 21:01 +0200, David Nystrom wrote:
> 
> On Sep 23, 2013 8:01 PM, "Mark Hatle" <mark.hatle@windriver.com>
> wrote:
> >
> > This looks to be the same as the 'native' package, but I don't think
> you can just add a BBCLASSEXTEND = "nativesdk"
> 
> It mostly is and I cant, your right.

Why not? Just the SRC_URI or other issues?

> > Perhaps (in 1.6) someone should look at merging the three back
> together.
> 
> Agree, the merged recipe will also get a bit messy, but probably
> easier to maintain than in its current state.
> 
> > If this is the same as the native version, I'd suggest adding a
> comment stating as much so we can hopefully keep them in sync.
> 
> Will do, will return with v2
> 
Well, I'm not happy with the idea of duplicating all this code.
shadow-native shouldn't exist and this makes things worse. With a few
minutes, I could write this patch:

http://git.yoctoproject.org/cgit.cgi/poky-contrib/commit/?h=rpurdie/t2&id=0730423fcda165a12112182b093d2f6df2f9c5eb

which at least makes the situation a bit less ugly. I guess I did spend
years doing these kinds of patches back when we had 50 versions of
everything and BBCLASSEXTEND didn't yet exist. With a few more minutes
perhaps I can get rid of the separate -native, now the differences are
clear. meld is a nice too for this kind of work btw.

Cheers,

Richard




  reply	other threads:[~2013-09-23 21:14 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-23 16:33 [PATCHv3] makedevs: add nativesdk to BBCLASSEXTENDS David Nyström
2013-09-23 16:34 ` [PATCH] shadow: Create recipe nativesdk-shadow David Nyström
2013-09-23 18:01   ` Mark Hatle
2013-09-23 19:01     ` David Nystrom
2013-09-23 21:14       ` Richard Purdie [this message]
2013-09-24  8:25         ` Richard Purdie
2013-09-24 14:30           ` David Nyström
2013-09-25 10:03             ` Richard Purdie
2013-09-25 12:24               ` David Nyström
2013-09-23 16:34 ` [PATCHv2] libpam: Avoid host contamination issue w. libprelude David Nyström

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1379970871.18603.265.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=david.c.nystrom@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.