From: Paulo Zanoni <przanoni@gmail.com>
To: intel-gfx@lists.freedesktop.org
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
Subject: [PATCH 0/5] Organize intel_drv.h
Date: Tue, 24 Sep 2013 13:52:52 -0300 [thread overview]
Message-ID: <1380041577-1511-1-git-send-email-przanoni@gmail.com> (raw)
From: Paulo Zanoni <paulo.r.zanoni@intel.com>
Hi
Daniel reccently complained that we keep adding stuff at the bottom of the file
and keep conflicting with each other. So on the first patch I completely
reorganize the file so that it lists functions per-file. With this, different
patches will mostly only conflict when adding new functions to the same file.
Besides this, patches 2-5 try to remove a few lines from intel_drv.h. All the
other functions seem to be either necessary or not trivial to remove.
These patches were written against Friday's tree, and got a simple conflict
today. They get bit-rot very quickly and will conflict with everybody else's
patches touching the same file. If we don't really want this, please speak :)
Also, feel free to suggest more changes on top of these, and flamewar about the
"extern" keywords.
Cheers,
Paulo
Paulo Zanoni (5):
drm/i915: reorganize intel_drv.h
drm/i915: make intel_pipe_has_type static
drm/i915: make intel_crtc_load_lut static
drm/i915: make intel_crtc_fb_gamma_{set,get} static
drm/i915: make hsw_{disable,restore}_lcpll static
drivers/gpu/drm/i915/intel_display.c | 214 ++++++++----------
drivers/gpu/drm/i915/intel_drv.h | 409 ++++++++++++++++++-----------------
drivers/gpu/drm/i915/intel_fb.c | 21 ++
3 files changed, 326 insertions(+), 318 deletions(-)
--
1.8.3.1
next reply other threads:[~2013-09-24 16:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-24 16:52 Paulo Zanoni [this message]
2013-09-24 16:52 ` [PATCH 1/5] drm/i915: reorganize intel_drv.h Paulo Zanoni
2013-09-24 16:52 ` [PATCH 2/5] drm/i915: make intel_pipe_has_type static Paulo Zanoni
2013-09-24 16:52 ` [PATCH 3/5] drm/i915: make intel_crtc_load_lut static Paulo Zanoni
2013-09-24 16:52 ` [PATCH 4/5] drm/i915: make intel_crtc_fb_gamma_{set, get} static Paulo Zanoni
2013-09-24 16:52 ` [PATCH 5/5] drm/i915: make hsw_{disable, restore}_lcpll static Paulo Zanoni
2013-09-24 17:31 ` [PATCH 0/5] Organize intel_drv.h Daniel Vetter
2013-09-24 18:48 ` [PATCH 6/5] drm/i915: remove "extern" keywords from intel_drv.h functions Paulo Zanoni
2013-09-24 19:09 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1380041577-1511-1-git-send-email-przanoni@gmail.com \
--to=przanoni@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=paulo.r.zanoni@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.