From: Geoff Levand <geoff@infradead.org>
To: Joe Perches <joe@perches.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Ishizaki Kou <kou.ishizaki@toshiba.co.jp>,
Jens Osterkamp <jens@de.ibm.com>,
cbe-oss-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 08/10] toshiba: Remove extern from function prototypes
Date: Tue, 24 Sep 2013 14:26:44 -0700 [thread overview]
Message-ID: <1380058004.9509.1.camel@smoke> (raw)
In-Reply-To: <3e0dd1f4722f8e0c10a47b9bbb26e891e79fef60.1380056108.git.joe@perches.com>
On Tue, 2013-09-24 at 14:10 -0700, Joe Perches wrote:
> There are a mix of function prototypes with and without extern
> in the kernel sources. Standardize on not using extern for
> function prototypes.
>
> Function prototypes don't need to be written with extern.
> extern is assumed by the compiler. Its use is as unnecessary as
> using auto to declare automatic/local variables in a block.
>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
> drivers/net/ethernet/toshiba/ps3_gelic_net.h | 29 +++++++++++------------
> drivers/net/ethernet/toshiba/ps3_gelic_wireless.h | 6 ++---
> drivers/net/ethernet/toshiba/spider_net.h | 4 ++--
> 3 files changed, 19 insertions(+), 20 deletions(-)
Looks good. Thanks.
Acked-by: Geoff Levand <geoff@infradead.org>
next prev parent reply other threads:[~2013-09-24 21:26 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-24 21:09 [PATCH 00/10 - GIT PULL] drivers: net: Next block of Remove extern from function prototypes Joe Perches
2013-09-24 21:09 ` Joe Perches
2013-09-24 21:09 ` [PATCH 01/10] ibm/emac: " Joe Perches
2013-09-24 21:09 ` [PATCH 02/10] intel: " Joe Perches
2013-09-24 22:07 ` Jeff Kirsher
2013-09-24 22:07 ` Jeff Kirsher
2013-09-24 22:16 ` Ben Hutchings
2013-09-25 1:34 ` David Miller
2013-09-24 22:22 ` Joe Perches
2013-09-24 22:22 ` Joe Perches
2013-09-24 21:09 ` [PATCH 03/10] oki-semi: " Joe Perches
2013-09-24 21:09 ` [PATCH 04/10] qlogic: " Joe Perches
2013-09-24 21:09 ` [PATCH 05/10] sfc: " Joe Perches
2013-09-24 21:10 ` [PATCH 06/10] stmicro: " Joe Perches
2013-09-24 21:10 ` [PATCH 07/10] ti: " Joe Perches
2013-09-24 21:10 ` [PATCH 08/10] toshiba: " Joe Perches
2013-09-24 21:26 ` Geoff Levand [this message]
2013-09-24 21:10 ` [PATCH 09/10] fddi/skfp: " Joe Perches
2013-09-24 21:10 ` [PATCH 10/10] irda: " Joe Perches
[not found] ` <OF686C5618.58B3CEF3-ONC1257BF0.0074538C-C1257BF0.00745392@de.ibm.com>
2013-09-24 21:21 ` [RFC patch] Update Jens Osterkamp email address Joe Perches
2013-09-24 21:45 ` Joe Perches
2013-09-25 19:04 ` [PATCH 00/10 - GIT PULL] drivers: net: Next block of Remove extern from function prototypes David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1380058004.9509.1.camel@smoke \
--to=geoff@infradead.org \
--cc=cbe-oss-dev@lists.ozlabs.org \
--cc=davem@davemloft.net \
--cc=jens@de.ibm.com \
--cc=joe@perches.com \
--cc=kou.ishizaki@toshiba.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.