All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yinghai Lu <yinghai@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
	Yinghai Lu <yinghai@kernel.org>
Subject: [PATCH] PCI: Workaround missing pci_set_master in pci drivers
Date: Sat, 28 Sep 2013 13:13:07 -0700	[thread overview]
Message-ID: <1380399187-4962-1-git-send-email-yinghai@kernel.org> (raw)
In-Reply-To: <1380337550.27811.71.camel@pasglop>

BenH found:
| 928bea964827d7824b548c1f8e06eccbbc4d0d7d
| PCI: Delay enabling bridges until they're needed

break PCI on powerpc.  The reason is that the PCIe port driver will
call pci_enable_device() on the bridge, so device enabled (but skip
pci_set_master because pcie_port_auto and no acpi on powerpc ).

Because of that, pci_enable_bridge() later on (called as a result of the
child device driver doing pci_enable_device) will see the bridge as
already enabled and will not call pci_set_master() on it.

Fixed by add checking in pci_enable_bridge, and call pci_set_master
if driver skip that.
That will make the code more robot and wade off problem for missing
pci_set_master in drivers.

Reported-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Yinghai Lu <yinghai@kernel.org>

---
 drivers/pci/pci.c |    8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

Index: linux-2.6/drivers/pci/pci.c
===================================================================
--- linux-2.6.orig/drivers/pci/pci.c
+++ linux-2.6/drivers/pci/pci.c
@@ -1156,8 +1156,14 @@ static void pci_enable_bridge(struct pci
 
 	pci_enable_bridge(dev->bus->self);
 
-	if (pci_is_enabled(dev))
+	if (pci_is_enabled(dev)) {
+		if (!dev->is_busmaster) {
+			dev_warn(&dev->dev, "driver skip pci_set_master, fix it!\n");
+			pci_set_master(dev);
+		}
 		return;
+	}
+
 	retval = pci_enable_device(dev);
 	if (retval)
 		dev_err(&dev->dev, "Error enabling bridge (%d), continuing\n",

  reply	other threads:[~2013-09-28 20:13 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-27  8:28 Please revert 928bea964827d7824b548c1f8e06eccbbc4d0d7d Benjamin Herrenschmidt
2013-09-27  8:28 ` Benjamin Herrenschmidt
2013-09-27 16:01 ` Yinghai Lu
2013-09-27 16:01   ` Yinghai Lu
2013-09-27 17:10   ` Linus Torvalds
2013-09-27 17:10     ` Linus Torvalds
2013-09-27 21:46     ` Benjamin Herrenschmidt
2013-09-27 21:46       ` Benjamin Herrenschmidt
2013-09-27 21:54       ` Yinghai Lu
2013-09-27 21:54         ` Yinghai Lu
2013-09-27 22:00         ` Benjamin Herrenschmidt
2013-09-27 22:00           ` Benjamin Herrenschmidt
2013-09-27 22:38         ` Benjamin Herrenschmidt
2013-09-27 22:38           ` Benjamin Herrenschmidt
2013-09-27 22:56           ` Yinghai Lu
2013-09-27 22:56             ` Yinghai Lu
2013-09-27 23:19             ` Benjamin Herrenschmidt
2013-09-27 23:19               ` Benjamin Herrenschmidt
2013-09-27 23:44               ` Yinghai Lu
2013-09-27 23:44                 ` Yinghai Lu
2013-09-28  3:05                 ` Benjamin Herrenschmidt
2013-09-28  3:05                   ` Benjamin Herrenschmidt
2013-09-28 20:13                   ` Yinghai Lu [this message]
2013-09-29 22:41                     ` [PATCH] PCI: Workaround missing pci_set_master in pci drivers Theodore Ts'o
2013-09-29 22:46                       ` Linus Torvalds
2013-09-29 22:57                         ` Theodore Ts'o
2013-10-03 22:06                     ` Bjorn Helgaas
2013-10-03 23:35                       ` Yinghai Lu
2013-10-04 15:55                         ` Bjorn Helgaas
2013-11-04 12:44                           ` Paul Bolle
2013-11-05 23:26                             ` Bjorn Helgaas
2013-09-28 20:14                   ` Please revert 928bea964827d7824b548c1f8e06eccbbc4d0d7d Yinghai Lu
2013-09-28 20:14                     ` Yinghai Lu
2013-09-29  0:40                 ` Rafael J. Wysocki
2013-09-29  0:40                   ` Rafael J. Wysocki
2013-09-27 17:44   ` Yinghai Lu
2013-09-27 17:44     ` Yinghai Lu
2013-09-27 22:15     ` Benjamin Herrenschmidt
2013-09-27 22:15       ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1380399187-4962-1-git-send-email-yinghai@kernel.org \
    --to=yinghai@kernel.org \
    --cc=benh@kernel.crashing.org \
    --cc=bhelgaas@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.