From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, afaerber@suse.de, kraxel@redhat.com
Subject: [Qemu-devel] [PATCH v6 04/26] qom: add pointer to int property helpers
Date: Sun, 29 Sep 2013 13:58:32 +0300 [thread overview]
Message-ID: <1380452123-5989-5-git-send-email-mst@redhat.com> (raw)
In-Reply-To: <1380452123-5989-1-git-send-email-mst@redhat.com>
Make it easy to add read-only helpers for simple
integer properties in memory.
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
include/qom/object.h | 21 ++++++++++++++++++
qom/object.c | 60 ++++++++++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 81 insertions(+)
diff --git a/include/qom/object.h b/include/qom/object.h
index e3a16e4..3b75f5a 100644
--- a/include/qom/object.h
+++ b/include/qom/object.h
@@ -795,6 +795,27 @@ void object_property_add(Object *obj, const char *name, const char *type,
void object_property_del(Object *obj, const char *name, Error **errp);
/**
+ * object_property_add_uint8_ptr:
+ * object_property_add_uint16_ptr:
+ * object_property_add_uint32_ptr:
+ * object_property_add_uint64_ptr:
+ * @obj: the object to add a property to
+ * @name: the name of the property
+ * @v: pointer to value
+ *
+ * Add an integer property in memory. This function will add a
+ * property of the appropriate type.
+ */
+void object_property_add_uint8_ptr(Object *obj, const char *name,
+ const uint8_t *v, Error **errp);
+void object_property_add_uint16_ptr(Object *obj, const char *name,
+ const uint16_t *v, Error **errp);
+void object_property_add_uint32_ptr(Object *obj, const char *name,
+ const uint32_t *v, Error **errp);
+void object_property_add_uint64_ptr(Object *obj, const char *name,
+ const uint64_t *v, Error **Errp);
+
+/**
* object_property_find:
* @obj: the object
* @name: the name of the property
diff --git a/qom/object.c b/qom/object.c
index e90e382..b617f26 100644
--- a/qom/object.c
+++ b/qom/object.c
@@ -1344,6 +1344,66 @@ static char *qdev_get_type(Object *obj, Error **errp)
return g_strdup(object_get_typename(obj));
}
+static void property_get_uint8_ptr(Object *obj, Visitor *v,
+ void *opaque, const char *name,
+ Error **errp)
+{
+ uint8_t value = *(uint8_t *)opaque;
+ visit_type_uint8(v, &value, name, errp);
+}
+
+static void property_get_uint16_ptr(Object *obj, Visitor *v,
+ void *opaque, const char *name,
+ Error **errp)
+{
+ uint16_t value = *(uint16_t *)opaque;
+ visit_type_uint16(v, &value, name, errp);
+}
+
+static void property_get_uint32_ptr(Object *obj, Visitor *v,
+ void *opaque, const char *name,
+ Error **errp)
+{
+ uint32_t value = *(uint32_t *)opaque;
+ visit_type_uint32(v, &value, name, errp);
+}
+
+static void property_get_uint64_ptr(Object *obj, Visitor *v,
+ void *opaque, const char *name,
+ Error **errp)
+{
+ uint64_t value = *(uint64_t *)opaque;
+ visit_type_uint64(v, &value, name, errp);
+}
+
+void object_property_add_uint8_ptr(Object *obj, const char *name,
+ const uint8_t *v, Error **errp)
+{
+ object_property_add(obj, name, "uint8", property_get_uint8_ptr,
+ NULL, NULL, (void *)v, errp);
+}
+
+void object_property_add_uint16_ptr(Object *obj, const char *name,
+ const uint16_t *v, Error **errp)
+{
+ object_property_add(obj, name, "uint16", property_get_uint16_ptr,
+ NULL, NULL, (void *)v, errp);
+}
+
+void object_property_add_uint32_ptr(Object *obj, const char *name,
+ const uint32_t *v, Error **errp)
+{
+ object_property_add(obj, name, "uint32", property_get_uint32_ptr,
+ NULL, NULL, (void *)v, errp);
+}
+
+void object_property_add_uint64_ptr(Object *obj, const char *name,
+ const uint64_t *v, Error **errp)
+{
+ object_property_add(obj, name, "uint64", property_get_uint64_ptr,
+ NULL, NULL, (void *)v, errp);
+}
+
static void object_instance_init(Object *obj)
{
object_property_add_str(obj, "type", qdev_get_type, NULL, NULL);
--
MST
next prev parent reply other threads:[~2013-09-29 10:56 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-29 10:58 [Qemu-devel] [PATCH v6 00/26] qemu: generate acpi tables for the guest Michael S. Tsirkin
2013-09-29 10:58 ` [Qemu-devel] [PATCH v6 01/26] qemu: add Error to typedefs Michael S. Tsirkin
2013-09-30 13:10 ` Igor Mammedov
2013-09-30 14:40 ` Michael S. Tsirkin
2013-09-30 15:00 ` Igor Mammedov
2013-09-30 15:10 ` Peter Maydell
2013-09-30 15:49 ` Markus Armbruster
2013-09-30 16:09 ` Michael S. Tsirkin
2013-09-30 17:38 ` Markus Armbruster
2013-09-30 15:50 ` Michael S. Tsirkin
2013-09-30 15:55 ` Andreas Färber
2013-09-30 16:09 ` Michael S. Tsirkin
2013-10-01 13:46 ` Igor Mammedov
2013-10-01 14:15 ` Michael S. Tsirkin
2013-10-01 15:44 ` [Qemu-devel] [PATCH] cleanup object.h: include error.h directly Igor Mammedov
2013-09-30 16:16 ` [Qemu-devel] [PATCH v6 01/26] qemu: add Error to typedefs Markus Armbruster
2013-09-29 10:58 ` [Qemu-devel] [PATCH v6 02/26] qom: pull in qemu/typedefs Michael S. Tsirkin
2013-09-29 10:58 ` [Qemu-devel] [PATCH v6 03/26] qom: cleanup struct Error references Michael S. Tsirkin
2013-09-29 10:58 ` Michael S. Tsirkin [this message]
2013-09-29 10:58 ` [Qemu-devel] [PATCH v6 05/26] fw_cfg: interface to trigger callback on read Michael S. Tsirkin
2013-09-29 10:58 ` [Qemu-devel] [PATCH v6 06/26] loader: support for unmapped ROM blobs Michael S. Tsirkin
2013-09-29 10:58 ` [Qemu-devel] [PATCH v6 07/26] pcie_host: expose UNMAPPED macro Michael S. Tsirkin
2013-09-29 10:58 ` [Qemu-devel] [PATCH v6 08/26] pcie_host: expose address format Michael S. Tsirkin
2013-09-29 10:58 ` [Qemu-devel] [PATCH v6 09/26] q35: use macro for MCFG property name Michael S. Tsirkin
2013-09-29 10:58 ` [Qemu-devel] [PATCH v6 10/26] q35: expose mmcfg size as a property Michael S. Tsirkin
2013-09-29 10:58 ` [Qemu-devel] [PATCH v6 11/26] i386: add ACPI table files from seabios Michael S. Tsirkin
2013-09-29 10:58 ` [Qemu-devel] [PATCH v6 12/26] acpi: add rules to compile ASL source Michael S. Tsirkin
2013-09-29 10:58 ` [Qemu-devel] [PATCH v6 13/26] acpi: pre-compiled ASL files Michael S. Tsirkin
2013-09-29 10:59 ` [Qemu-devel] [PATCH v6 14/26] acpi: ssdt pcihp: updat generated file Michael S. Tsirkin
2013-09-29 10:59 ` [Qemu-devel] [PATCH v6 15/26] loader: use file path size from fw_cfg.h Michael S. Tsirkin
2013-09-29 10:59 ` [Qemu-devel] [PATCH v6 16/26] i386: add bios linker/loader Michael S. Tsirkin
2013-09-29 10:59 ` [Qemu-devel] [PATCH v6 17/26] loader: allow adding ROMs in done callbacks Michael S. Tsirkin
2013-09-29 10:59 ` [Qemu-devel] [PATCH v6 18/26] i386: define pc guest info Michael S. Tsirkin
2013-09-29 10:59 ` [Qemu-devel] [PATCH v6 19/26] acpi/piix: add macros for acpi property names Michael S. Tsirkin
2013-09-29 10:59 ` [Qemu-devel] [PATCH v6 20/26] piix: APIs for pc guest info Michael S. Tsirkin
2013-09-29 10:59 ` [Qemu-devel] [PATCH v6 21/26] ich9: " Michael S. Tsirkin
2013-09-29 10:59 ` [Qemu-devel] [PATCH v6 22/26] pvpanic: add API to access io port Michael S. Tsirkin
2013-09-29 10:59 ` [Qemu-devel] [PATCH v6 23/26] hpet: add API to find it Michael S. Tsirkin
2013-09-29 10:59 ` [Qemu-devel] [PATCH v6 24/26] i386: ACPI table generation code from seabios Michael S. Tsirkin
2013-09-29 10:59 ` [Qemu-devel] [PATCH v6 25/26] ssdt: fix PBLK length Michael S. Tsirkin
2013-09-29 11:01 ` [Qemu-devel] [PATCH v6 26/26] ssdt-proc: update generated file Michael S. Tsirkin
2013-09-30 7:51 ` [Qemu-devel] [PATCH v6 00/26] qemu: generate acpi tables for the guest Gerd Hoffmann
2013-10-01 10:03 ` Igor Mammedov
2013-10-01 12:16 ` Michael S. Tsirkin
2013-10-01 12:38 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1380452123-5989-5-git-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=afaerber@suse.de \
--cc=kraxel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.