All of lore.kernel.org
 help / color / mirror / Atom feed
From: James Bottomley <jbottomley@parallels.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Bart Van Assche <bvanassche@acm.org>,
	Mike Christie <michaelc@cs.wisc.edu>,
	Hannes Reinecke <hare@suse.de>,
	David Milburn <dmilburn@redhat.com>,
	linux-scsi <linux-scsi@vger.kernel.org>
Subject: Re: SCSI core patches for kernel 3.12
Date: Wed, 2 Oct 2013 15:15:20 +0000	[thread overview]
Message-ID: <1380726918.2081.43.camel@dabdike> (raw)
In-Reply-To: <20131002074006.GA8994@infradead.org>

And I thought the world was ending when Linus started top posting ...

On Wed, 2013-10-02 at 00:40 -0700, Christoph Hellwig wrote:
> James, and comments on this?

You mean apart from the fact that it's a long series which seems to self
confess to providing not much value and therefore not rating itself high
on the review list?

So if I get the gist, the only real value is removing a pair of get/put
calls in the critical path, so produce a single patch doing that and it
will all go a lot faster than having to review seven code movement and
pointless rename patches.

James

> On Tue, Aug 20, 2013 at 02:05:45PM +0200, Bart Van Assche wrote:
> > This patch series consists of four patches that address device
> > removal issues and three patches that improve performance of the
> > SCSI mid-layer.
> > 
> > The individual patches are.
> > 0001-Introduce-scsi_device_being_removed.patch
> > 0002-Rework-scsi_internal_device_unblock.patch
> > 0003-Avoid-re-enabling-I-O-after-the-transport-became-off.patch
> > 0004-Disallow-changing-the-device-state-via-sysfs-into-de.patch
> > 0005-Micro-optimize-scsi_request_fn.patch
> > 0006-Rename-scsi_get_command-and-scsi_put_command.patch
> > 0007-Micro-optimize-scsi_next_command.patch
> > 
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> ---end quoted text---
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



  reply	other threads:[~2013-10-02 15:16 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-20 12:05 SCSI core patches for kernel 3.12 Bart Van Assche
2013-08-20 12:06 ` [PATCH 1/7] Introduce scsi_device_being_removed() Bart Van Assche
2013-09-01 16:43   ` Christoph Hellwig
2013-08-20 12:07 ` [PATCH 2/7] Rework scsi_internal_device_unblock() Bart Van Assche
2013-09-01 16:44   ` Christoph Hellwig
2013-08-20 12:08 ` [PATCH 3/7] Avoid re-enabling I/O after the transport became offline Bart Van Assche
2013-09-01 16:46   ` Christoph Hellwig
2013-08-20 12:08 ` [PATCH 4/7] Disallow changing the device state via sysfs into "deleted" Bart Van Assche
2013-09-01 16:49   ` Christoph Hellwig
2013-09-02 18:59     ` Bart Van Assche
2013-09-02 19:06       ` Christoph Hellwig
2013-09-02 19:12         ` Bart Van Assche
2013-09-02 19:17           ` Christoph Hellwig
2013-08-20 12:09 ` [PATCH 5/7] Micro-optimize scsi_request_fn() Bart Van Assche
2013-09-01 16:50   ` Christoph Hellwig
2013-08-20 12:09 ` [PATCH 6/7] Rename scsi_get_command() and scsi_put_command() Bart Van Assche
2013-08-20 12:10 ` [PATCH 7/7] Micro-optimize scsi_next_command() Bart Van Assche
2013-09-01 17:06   ` Christoph Hellwig
2013-09-01 17:08     ` [PATCH 8/7] scsi: cleanup scsi_requeue_command Christoph Hellwig
2013-08-20 16:11 ` SCSI core patches for kernel 3.12 Nicholas A. Bellinger
2013-08-20 16:15   ` Bart Van Assche
2013-08-20 17:04     ` Nicholas A. Bellinger
2013-08-20 18:00       ` Bart Van Assche
2013-08-20 20:38         ` Nicholas A. Bellinger
2013-08-21  6:48           ` Christoph Hellwig
2013-08-21  7:35             ` Nicholas A. Bellinger
2013-10-02  7:40 ` Christoph Hellwig
2013-10-02 15:15   ` James Bottomley [this message]
2013-10-02 16:17     ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1380726918.2081.43.camel@dabdike \
    --to=jbottomley@parallels.com \
    --cc=bvanassche@acm.org \
    --cc=dmilburn@redhat.com \
    --cc=hare@suse.de \
    --cc=hch@infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=michaelc@cs.wisc.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.