All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Rudorff <chris-4cZEHNAa5IdBDgjK7y7TUQ@public.gmane.org>
To: Emil Velikov <emil.l.velikov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
	Ben Skeggs <bskeggs-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH] drm/nouveau/fb: fix suspend/resume fbcon
Date: Fri, 04 Oct 2013 02:54:59 +0200	[thread overview]
Message-ID: <1380848099.8990.15.camel@localhost> (raw)
In-Reply-To: <524DF4CF.6040907-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

Am Donnerstag, den 03.10.2013, 23:50 +0100 schrieb Emil Velikov:
> I'm not entirely sure this is correct. One needs to save and disable
> accleration before suspending the fb. Please try the following
> 
> -	if (state == 0)
> +	if (state == 1)
> 		nouveau_fbcon_save_disable_accel(dev);
> 	fb_set_suspend(drm->fbcon->helper.fbdev, state);
> -	if (state == 1)
> +	if (state == 0)
> 		nouveau_fbcon_restore_accel(dev);
> 	console_unlock();
> 
> Cheers,
> Emil

Hi!

That was my first try! I guessed the same but I got exactly one trap
message on resume.

So it's about first put the bucket and then open the water tap.

;)

chris

ps: just found these macros for the state in fb.h:

FBINFO_STATE_RUNNING = 0
FBINFO_STATE_SUSPENDED = 1

  parent reply	other threads:[~2013-10-04  0:54 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-03 14:41 [PATCH] drm/nouveau/fb: fix suspend/resume fbcon Christoph Rudorff
2013-10-03 22:50 ` Emil Velikov
     [not found]   ` <524DF4CF.6040907-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-10-04  0:54     ` Christoph Rudorff [this message]
2013-11-16 23:22       ` Emil Velikov
     [not found]         ` <5287FE3D.7070708-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-11-17 18:30           ` Christoph Rudorff
     [not found]             ` <52890B39.30700-4cZEHNAa5IdBDgjK7y7TUQ@public.gmane.org>
2013-11-18 16:45               ` Emil Velikov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1380848099.8990.15.camel@localhost \
    --to=chris-4czehnaa5idbdgjk7y7tuq@public.gmane.org \
    --cc=bskeggs-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=emil.l.velikov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.