From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: "cristiana.voicu" <cristiana.voicu@intel.com>
Cc: bitbake-devel@lists.openembedded.org
Subject: Re: [PATCH] HOB: MACHINE should be saved in conf files using ?=
Date: Fri, 04 Oct 2013 14:37:14 +0100 [thread overview]
Message-ID: <1380893834.18603.608.camel@ted> (raw)
In-Reply-To: <524D70DD.7050709@intel.com>
On Thu, 2013-10-03 at 16:27 +0300, cristiana.voicu wrote:
> I know I replied with an ack for this patch, but working on a similar
> bug I realized that replacing the comment "total += "\n#added by
> bitbake" with total += "\n#added by hob" in bitbake code is not ok. I
> think it will be better to give as argument the comment string, in order
> to keep this method reusable in other ui.
To make things simpler can someone send a follow up patch to make this a
parameter please?
Cheers,
Richard
next prev parent reply other threads:[~2013-10-04 13:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-27 14:10 [PATCH] HOB: MACHINE should be saved in conf files using ?= Valentin Popa
2013-09-30 7:34 ` cristiana.voicu
2013-10-03 13:27 ` cristiana.voicu
2013-10-04 13:37 ` Richard Purdie [this message]
2013-10-04 16:29 ` Valentin Popa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1380893834.18603.608.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=bitbake-devel@lists.openembedded.org \
--cc=cristiana.voicu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.