From: Peter Lieven <pl@kamp.de>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, ronniesahlberg@gmail.com,
Peter Lieven <pl@kamp.de>,
stefanha@redhat.com, anthony@codemonkey.ws, pbonzini@redhat.com
Subject: [Qemu-devel] [PATCHv4 15/17] qemu-img: add support for fully allocated images
Date: Tue, 8 Oct 2013 13:58:09 +0200 [thread overview]
Message-ID: <1381233491-17019-16-git-send-email-pl@kamp.de> (raw)
In-Reply-To: <1381233491-17019-1-git-send-email-pl@kamp.de>
Signed-off-by: Peter Lieven <pl@kamp.de>
---
qemu-img.c | 8 +++++---
qemu-img.texi | 5 +++++
2 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/qemu-img.c b/qemu-img.c
index 926f0a0..c6eff15 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -100,8 +100,10 @@ static void help(void)
" '-h' with or without a command shows this help and lists the supported formats\n"
" '-p' show progress of command (only certain commands)\n"
" '-q' use Quiet mode - do not print any output (except errors)\n"
- " '-S' indicates the consecutive number of bytes that must contain only zeros\n"
- " for qemu-img to create a sparse image during conversion\n"
+ " '-S' indicates the consecutive number of bytes (defaults to 4k) that must\n"
+ " contain only zeros for qemu-img to create a sparse image during\n"
+ " conversion. if the number of bytes is 0 sparse files are disabled and\n"
+ " images will always be fully allocated\n"
" '--output' takes the format in which the output must be done (human or json)\n"
" '-n' skips the target volume creation (useful if the volume is created\n"
" prior to running qemu-img)\n"
@@ -1465,7 +1467,7 @@ static int img_convert(int argc, char **argv)
/* signal EOF to align */
bdrv_write_compressed(out_bs, 0, NULL, 0);
} else {
- int has_zero_init = bdrv_has_zero_init(out_bs);
+ int has_zero_init = min_sparse ? bdrv_has_zero_init(out_bs) : 0;
sector_num = 0; // total number of sectors converted so far
nb_sectors = total_sectors - sector_num;
diff --git a/qemu-img.texi b/qemu-img.texi
index 768054e..51a1ee5 100644
--- a/qemu-img.texi
+++ b/qemu-img.texi
@@ -193,6 +193,11 @@ Image conversion is also useful to get smaller image when using a
growable format such as @code{qcow} or @code{cow}: the empty sectors
are detected and suppressed from the destination image.
+@var{sparse_size} indicates the consecutive number of bytes (defaults to 4k)
+that must contain only zeros for qemu-img to create a sparse image during
+conversion. If the number of bytes is 0 sparse files are disabled and
+images will always be fully allocated.
+
You can use the @var{backing_file} option to force the output image to be
created as a copy on write image of the specified base image; the
@var{backing_file} should have the same content as the input's base image,
--
1.7.9.5
next prev parent reply other threads:[~2013-10-08 12:02 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-08 11:57 [Qemu-devel] [PATCHv4 00/17] block: logical block provisioning enhancements Peter Lieven
2013-10-08 11:57 ` [Qemu-devel] [PATCHv4 01/17] block: make BdrvRequestFlags public Peter Lieven
2013-10-08 11:57 ` [Qemu-devel] [PATCHv4 02/17] block: add flags to bdrv_*_write_zeroes Peter Lieven
2013-10-08 11:57 ` [Qemu-devel] [PATCHv4 03/17] block: introduce BDRV_REQ_MAY_UNMAP request flag Peter Lieven
2013-10-08 11:57 ` [Qemu-devel] [PATCHv4 04/17] block: introduce bdrv_has_discard_zeroes and bdrv_has_discard_write_zeroes Peter Lieven
2013-10-08 11:57 ` [Qemu-devel] [PATCHv4 05/17] block/raw: add " Peter Lieven
2013-10-08 11:58 ` [Qemu-devel] [PATCHv4 06/17] block: add BlockLimits structure to BlockDriverState Peter Lieven
2013-10-08 11:58 ` [Qemu-devel] [PATCHv4 07/17] block: honour BlockLimits in bdrv_co_do_write_zeroes Peter Lieven
2013-10-08 11:58 ` [Qemu-devel] [PATCHv4 08/17] block: honour BlockLimits in bdrv_co_discard Peter Lieven
2013-10-08 11:58 ` [Qemu-devel] [PATCHv4 09/17] iscsi: simplify iscsi_co_discard Peter Lieven
2013-10-08 11:58 ` [Qemu-devel] [PATCHv4 10/17] iscsi: set limits in BlockDriverState Peter Lieven
2013-10-08 11:58 ` [Qemu-devel] [PATCHv4 11/17] iscsi: add bdrv_has_discard_zeroes and bdrv_has_discard_write_zeroes Peter Lieven
2013-10-08 11:58 ` [Qemu-devel] [PATCHv4 12/17] iscsi: add bdrv_co_write_zeroes Peter Lieven
2013-10-08 11:58 ` [Qemu-devel] [PATCHv4 13/17] block: introduce bdrv_make_zero Peter Lieven
2013-10-08 11:58 ` [Qemu-devel] [PATCHv4 14/17] block/get_block_status: fix BDRV_BLOCK_ZERO for unallocated blocks Peter Lieven
2013-10-18 12:38 ` Stefan Hajnoczi
2013-10-18 12:49 ` Paolo Bonzini
2013-10-18 13:24 ` Stefan Hajnoczi
2013-10-18 13:52 ` Peter Lieven
2013-10-18 13:58 ` Paolo Bonzini
2013-10-18 13:26 ` Peter Lieven
2013-10-18 13:50 ` Paolo Bonzini
2013-10-18 19:10 ` Peter Lieven
2013-10-30 8:28 ` Stefan Hajnoczi
2013-10-30 21:22 ` Peter Lieven
2013-10-18 13:20 ` Peter Lieven
2013-10-08 11:58 ` Peter Lieven [this message]
2013-10-08 11:58 ` [Qemu-devel] [PATCHv4 16/17] qemu-img: conditionally zero out target on convert Peter Lieven
2013-10-18 12:26 ` Stefan Hajnoczi
2013-10-08 11:58 ` [Qemu-devel] [PATCHv4 17/17] block/raw: copy BlockLimits on raw_open Peter Lieven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1381233491-17019-16-git-send-email-pl@kamp.de \
--to=pl@kamp.de \
--cc=anthony@codemonkey.ws \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=ronniesahlberg@gmail.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.