From: Jonathan Liu <net147@gmail.com>
To: openembedded-devel@lists.openembedded.org
Subject: [meta-qt5][PATCH] qtbase: add upstream QTBUG-31579 patch for QPainter regression
Date: Thu, 10 Oct 2013 00:20:56 +1100 [thread overview]
Message-ID: <1381324856-24216-1-git-send-email-net147@gmail.com> (raw)
Signed-off-by: Jonathan Liu <net147@gmail.com>
---
...Pixel.y-is-also-initalized-to-1-when-nece.patch | 47 ++++++++++++++++++++++
...Pixel.y-is-also-initalized-to-1-when-nece.patch | 47 ++++++++++++++++++++++
recipes-qt/qt5/qtbase.inc | 1 +
3 files changed, 95 insertions(+)
create mode 100644 recipes-qt/qt5/qtbase-5.1.0/0026-Ensure-lastPixel.y-is-also-initalized-to-1-when-nece.patch
create mode 100644 recipes-qt/qt5/qtbase-git/0026-Ensure-lastPixel.y-is-also-initalized-to-1-when-nece.patch
diff --git a/recipes-qt/qt5/qtbase-5.1.0/0026-Ensure-lastPixel.y-is-also-initalized-to-1-when-nece.patch b/recipes-qt/qt5/qtbase-5.1.0/0026-Ensure-lastPixel.y-is-also-initalized-to-1-when-nece.patch
new file mode 100644
index 0000000..0d53305
--- /dev/null
+++ b/recipes-qt/qt5/qtbase-5.1.0/0026-Ensure-lastPixel.y-is-also-initalized-to-1-when-nece.patch
@@ -0,0 +1,47 @@
+From f0b950144dde85b65df0c3cf83f7c8df0e94bbbf Mon Sep 17 00:00:00 2001
+From: Andy Shaw <andy.shaw@digia.com>
+Date: Tue, 8 Oct 2013 15:45:42 +0200
+Subject: [PATCH] Ensure lastPixel.y is also initalized to -1 when necessary
+
+Task-number: QTBUG-31579
+
+Upstream-Status: Accepted [https://codereview.qt-project.org/#change,67578]
+Signed-off-by: Jonathan Liu <net147@gmail.com>
+
+Change-Id: Ia4916ac0d384ea523bbfad0dafbc90044da7ec3e
+Reviewed-by: Gunnar Sletta <gunnar.sletta@digia.com>
+---
+ src/gui/painting/qcosmeticstroker.cpp | 3 +++
+ 1 file changed, 3 insertions(+)
+
+diff --git a/src/gui/painting/qcosmeticstroker.cpp b/src/gui/painting/qcosmeticstroker.cpp
+index 39f6422..a2301e3 100644
+--- a/src/gui/painting/qcosmeticstroker.cpp
++++ b/src/gui/painting/qcosmeticstroker.cpp
+@@ -305,6 +305,7 @@ void QCosmeticStroker::setup()
+ ymax = deviceRect.bottom() + 2;
+
+ lastPixel.x = -1;
++ lastPixel.y = -1;
+ }
+
+ // returns true if the whole line gets clipped away
+@@ -533,6 +534,7 @@ void QCosmeticStroker::drawPath(const QVectorPath &path)
+ QPointF p = QPointF(points[0], points[1]) * state->matrix;
+ patternOffset = state->lastPen.dashOffset()*64;
+ lastPixel.x = -1;
++ lastPixel.y = -1;
+
+ bool closed;
+ const QPainterPath::ElementType *e = subPath(type, end, points, &closed);
+@@ -587,6 +589,7 @@ void QCosmeticStroker::drawPath(const QVectorPath &path)
+ QPointF movedTo = p;
+ patternOffset = state->lastPen.dashOffset()*64;
+ lastPixel.x = -1;
++ lastPixel.y = -1;
+
+ const qreal *begin = points;
+ const qreal *end = points + 2*path.elementCount();
+--
+1.8.4
+
diff --git a/recipes-qt/qt5/qtbase-git/0026-Ensure-lastPixel.y-is-also-initalized-to-1-when-nece.patch b/recipes-qt/qt5/qtbase-git/0026-Ensure-lastPixel.y-is-also-initalized-to-1-when-nece.patch
new file mode 100644
index 0000000..0d53305
--- /dev/null
+++ b/recipes-qt/qt5/qtbase-git/0026-Ensure-lastPixel.y-is-also-initalized-to-1-when-nece.patch
@@ -0,0 +1,47 @@
+From f0b950144dde85b65df0c3cf83f7c8df0e94bbbf Mon Sep 17 00:00:00 2001
+From: Andy Shaw <andy.shaw@digia.com>
+Date: Tue, 8 Oct 2013 15:45:42 +0200
+Subject: [PATCH] Ensure lastPixel.y is also initalized to -1 when necessary
+
+Task-number: QTBUG-31579
+
+Upstream-Status: Accepted [https://codereview.qt-project.org/#change,67578]
+Signed-off-by: Jonathan Liu <net147@gmail.com>
+
+Change-Id: Ia4916ac0d384ea523bbfad0dafbc90044da7ec3e
+Reviewed-by: Gunnar Sletta <gunnar.sletta@digia.com>
+---
+ src/gui/painting/qcosmeticstroker.cpp | 3 +++
+ 1 file changed, 3 insertions(+)
+
+diff --git a/src/gui/painting/qcosmeticstroker.cpp b/src/gui/painting/qcosmeticstroker.cpp
+index 39f6422..a2301e3 100644
+--- a/src/gui/painting/qcosmeticstroker.cpp
++++ b/src/gui/painting/qcosmeticstroker.cpp
+@@ -305,6 +305,7 @@ void QCosmeticStroker::setup()
+ ymax = deviceRect.bottom() + 2;
+
+ lastPixel.x = -1;
++ lastPixel.y = -1;
+ }
+
+ // returns true if the whole line gets clipped away
+@@ -533,6 +534,7 @@ void QCosmeticStroker::drawPath(const QVectorPath &path)
+ QPointF p = QPointF(points[0], points[1]) * state->matrix;
+ patternOffset = state->lastPen.dashOffset()*64;
+ lastPixel.x = -1;
++ lastPixel.y = -1;
+
+ bool closed;
+ const QPainterPath::ElementType *e = subPath(type, end, points, &closed);
+@@ -587,6 +589,7 @@ void QCosmeticStroker::drawPath(const QVectorPath &path)
+ QPointF movedTo = p;
+ patternOffset = state->lastPen.dashOffset()*64;
+ lastPixel.x = -1;
++ lastPixel.y = -1;
+
+ const qreal *begin = points;
+ const qreal *end = points + 2*path.elementCount();
+--
+1.8.4
+
diff --git a/recipes-qt/qt5/qtbase.inc b/recipes-qt/qt5/qtbase.inc
index b6927d1..ffd5af4 100644
--- a/recipes-qt/qt5/qtbase.inc
+++ b/recipes-qt/qt5/qtbase.inc
@@ -23,6 +23,7 @@ SRC_URI += " \
file://0023-configure-make-freetype-a-configurable-option.patch \
file://0024-Use-OE_QMAKE_PATH_EXTERNAL_HOST_BINS-to-determine-pa.patch \
file://0025-QHttpMultiPart-fix-data-corruption-in-readData-metho.patch \
+ file://0026-Ensure-lastPixel.y-is-also-initalized-to-1-when-nece.patch \
"
DEPENDS += "qtbase-native"
--
1.8.4
reply other threads:[~2013-10-09 13:22 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1381324856-24216-1-git-send-email-net147@gmail.com \
--to=net147@gmail.com \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.