All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Khem Raj <raj.khem@gmail.com>
Cc: openembedded-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] cross-canadian: Fix SHLIBSDIR when using multilib
Date: Tue, 15 Oct 2013 15:51:49 +0100	[thread overview]
Message-ID: <1381848709.29912.424.camel@ted> (raw)
In-Reply-To: <CAMKF1sr=L9W+T1izdxJGRznd3BnZLYW58qPs0y5EnRkETZp68A@mail.gmail.com>

On Tue, 2013-10-15 at 07:45 -0700, Khem Raj wrote:
> On Tue, Oct 15, 2013 at 6:40 AM, Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> > Both nativesdk and multilib use MLPREFIX for their partciular purposes. When
> > we have both set, cross-canadian can confuse SHLIBSDIR. This forces the
> > variable to the correct value for cross-canadian, fixing toolchains in
> > multilib builds.
> >
> > [YOCTO #5333]
> >
> > Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> > ---
> > diff --git a/meta/classes/cross-canadian.bbclass b/meta/classes/cross-canadian.bbclass
> > index 4387d05..7181c60 100644
> > --- a/meta/classes/cross-canadian.bbclass
> > +++ b/meta/classes/cross-canadian.bbclass
> > @@ -95,3 +95,8 @@ USE_NLS = "${SDKUSE_NLS}"
> >  # We have to us TARGET_ARCH but we care about the absolute value
> >  # and not any particular tune that is enabled.
> >  TARGET_ARCH[vardepsexclude] = "TUNE_ARCH"
> > +
> > +# If MLPREFIX is set by multilib code, shlibs
> > +# points to the wrong place so force it
> > +SHLIBSDIRS = "${PKGDATA_DIR}/nativesdk-shlibs"
> > +SHLIBSWORKDIR = "${PKGDATA_DIR}/nativesdk-shlibs"
> 
> in the patch that did not work for me
> I was using ${SDKPKGSUFFIX} instead of hardcoding 'nativesdk'
> and += instead of =

Well, one of the fields only takes a single value and there is only one
correct value here so = is more correct. I also needed my preceding
patch but I tested this and it did work afterwards...

You could try this (and the other patch) and see if it helps?

Cheers,

Richard



  reply	other threads:[~2013-10-15 14:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-15 13:40 [PATCH] cross-canadian: Fix SHLIBSDIR when using multilib Richard Purdie
2013-10-15 14:45 ` Khem Raj
2013-10-15 14:51   ` Richard Purdie [this message]
2013-10-15 15:08     ` Khem Raj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1381848709.29912.424.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=raj.khem@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.