All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Darren Hart <dvhart@linux.intel.com>
Cc: Tom Zanussi <tom.zanussi@linux.intel.com>,
	openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 3/3] wic: add fakeroot to the populate-extfs step
Date: Wed, 16 Oct 2013 17:32:21 +0100	[thread overview]
Message-ID: <1381941141.29912.494.camel@ted> (raw)
In-Reply-To: <1381939546.23041.123.camel@dvhart-mobl4.amr.corp.intel.com>

On Wed, 2013-10-16 at 09:05 -0700, Darren Hart wrote:
> On Wed, 2013-10-16 at 08:10 -0700, Darren Hart wrote:
> > On Wed, 2013-10-16 at 13:09 +0100, Richard Purdie wrote:
> > > On Wed, 2013-10-16 at 00:14 -0500, Tom Zanussi wrote:
> > > > Without this, files in the generated filesystem pick up the wrong
> > > > ownership.
> > > > 
> > > > Signed-off-by: Tom Zanussi <tom.zanussi@linux.intel.com>
> > > > ---
> > > >  scripts/lib/mic/kickstart/custom_commands/partition.py | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > > 
> > > > diff --git a/scripts/lib/mic/kickstart/custom_commands/partition.py b/scripts/lib/mic/kickstart/custom_commands/partition.py
> > > > index 302cace..309abee 100644
> > > > --- a/scripts/lib/mic/kickstart/custom_commands/partition.py
> > > > +++ b/scripts/lib/mic/kickstart/custom_commands/partition.py
> > > > @@ -216,7 +216,7 @@ class Wic_PartData(Mic_PartData):
> > > >          """
> > > >          Prepare content for an ext2/3/4 rootfs partition.
> > > >          """
> > > > -        populate_script = "%s/usr/bin/populate-extfs.sh" % native_sysroot
> > > > +        populate_script = "fakeroot %s/usr/bin/populate-extfs.sh" % native_sysroot
> > > >          image_extra_space = 10240
> > > >  
> > > >          image_rootfs = rootfs_dir
> > > 
> > > We don't use fakeroot, please use pseudo. If pseudo doesn't work, we
> > > need to figure out why and fix it.
> > > 
> > 
> > Ultimately this needs to work independently from bitbake. Is that
> > practical if we use pseudo here?
> 
> Starting to get a bit out of scope for this discussion, but it does
> impact the utility of the tool. I don't see a package for pseudo in
> either Ubuntu or Fedora. The lack of a package would definitely increase
> the barrier to use (lots of people really dislike having to build their
> own sources and muck up their filesystem with non-package files).
> 
> Has any work already been kicked off to try and get pseudo packaged in
> the major distributions? Who would the right people be to work with on
> that?
> 
> BTW, I'm not arguing for using fakeroot here, just trying to look at the
> big picture of using wic and what additional effort might be required to
> make it successful.

I understand that, I'd suggest one solution of pointing people at our
standalone buildtools tarball which we can easily include pseudo in. It
would also be nice to see it as a tool in its own right in distros.

My main worry is that we did used to run into a lot of weird fakeroot
bugs, I really don't want to end up there again...

Cheers,

Richard







      reply	other threads:[~2013-10-16 16:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-16  5:14 [PATCH 0/3] a few wic fixes Tom Zanussi
2013-10-16  5:14 ` [PATCH 1/3] wic: check for build artifacts Tom Zanussi
2013-10-16  5:14 ` [PATCH 2/3] wic: check passed-in build artifact directories Tom Zanussi
2013-10-16  5:14 ` [PATCH 3/3] wic: add fakeroot to the populate-extfs step Tom Zanussi
2013-10-16 12:09   ` Richard Purdie
2013-10-16 15:10     ` Darren Hart
2013-10-16 15:36       ` Richard Purdie
2013-10-16 16:05       ` Darren Hart
2013-10-16 16:32         ` Richard Purdie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1381941141.29912.494.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=dvhart@linux.intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=tom.zanussi@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.