All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Lieven <pl@kamp.de>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>, Peter Lieven <pl@kamp.de>,
	ronniesahlberg@gmail.com, pbonzini@redhat.com
Subject: [Qemu-devel] [PATCHv5 05/17] block: add wrappers for logical block provisioning information
Date: Sun, 20 Oct 2013 17:42:59 +0200	[thread overview]
Message-ID: <1382283791-11181-6-git-send-email-pl@kamp.de> (raw)
In-Reply-To: <1382283791-11181-1-git-send-email-pl@kamp.de>

This adds 2 wrappers to read the unallocated_blocks_are_zero and
can_write_zeroes_with_unmap info from the BDI. The wrappers are
required to check for the existence of a backing_hd and
if the devices are opened with the correct flags.

Signed-off-by: Peter Lieven <pl@kamp.de>
---
 block.c               |   30 ++++++++++++++++++++++++++++++
 include/block/block.h |    2 ++
 2 files changed, 32 insertions(+)

diff --git a/block.c b/block.c
index 0d97ce6..0601b02 100644
--- a/block.c
+++ b/block.c
@@ -3094,6 +3094,36 @@ int bdrv_has_zero_init(BlockDriverState *bs)
     return 0;
 }
 
+bool bdrv_unallocated_blocks_are_zero(BlockDriverState *bs)
+{
+    BlockDriverInfo bdi;
+
+    if (bs->backing_hd) {
+        return false;
+    }
+
+    if (bdrv_get_info(bs, &bdi) == 0) {
+        return bdi.unallocated_blocks_are_zero;
+    }
+
+    return false;
+}
+
+bool bdrv_can_write_zeroes_with_unmap(BlockDriverState *bs)
+{
+    BlockDriverInfo bdi;
+
+    if (bs->backing_hd || !(bs->open_flags & BDRV_O_UNMAP)) {
+        return false;
+    }
+
+    if (bdrv_get_info(bs, &bdi) == 0) {
+        return bdi.can_write_zeroes_with_unmap;
+    }
+
+    return false;
+}
+
 typedef struct BdrvCoGetBlockStatusData {
     BlockDriverState *bs;
     BlockDriverState *base;
diff --git a/include/block/block.h b/include/block/block.h
index 5fbab01..de0d6ab 100644
--- a/include/block/block.h
+++ b/include/block/block.h
@@ -344,6 +344,8 @@ int bdrv_discard(BlockDriverState *bs, int64_t sector_num, int nb_sectors);
 int bdrv_co_discard(BlockDriverState *bs, int64_t sector_num, int nb_sectors);
 int bdrv_has_zero_init_1(BlockDriverState *bs);
 int bdrv_has_zero_init(BlockDriverState *bs);
+bool bdrv_unallocated_blocks_are_zero(BlockDriverState *bs);
+bool bdrv_can_write_zeroes_with_unmap(BlockDriverState *bs);
 int64_t bdrv_get_block_status(BlockDriverState *bs, int64_t sector_num,
                               int nb_sectors, int *pnum);
 int bdrv_is_allocated(BlockDriverState *bs, int64_t sector_num, int nb_sectors,
-- 
1.7.9.5

  parent reply	other threads:[~2013-10-20 15:43 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-20 15:42 [Qemu-devel] [PATCHv5 00/17] block: logical block provisioning enhancements Peter Lieven
2013-10-20 15:42 ` [Qemu-devel] [PATCHv5 01/17] block: make BdrvRequestFlags public Peter Lieven
2013-10-20 15:42 ` [Qemu-devel] [PATCHv5 02/17] block: add flags to bdrv_*_write_zeroes Peter Lieven
2013-10-20 15:42 ` [Qemu-devel] [PATCHv5 03/17] block: introduce BDRV_REQ_MAY_UNMAP request flag Peter Lieven
2013-10-20 15:42 ` [Qemu-devel] [PATCHv5 04/17] block: add logical block provisioning info to BlockDriverInfo Peter Lieven
2013-10-22 13:26   ` Eric Blake
2013-10-20 15:42 ` Peter Lieven [this message]
2013-10-22 13:28   ` [Qemu-devel] [PATCHv5 05/17] block: add wrappers for logical block provisioning information Eric Blake
2013-10-20 15:43 ` [Qemu-devel] [PATCHv5 06/17] block/iscsi: add .bdrv_get_info Peter Lieven
2013-10-20 15:43 ` [Qemu-devel] [PATCHv5 07/17] block: add BlockLimits structure to BlockDriverState Peter Lieven
2013-10-20 15:43 ` [Qemu-devel] [PATCHv5 08/17] block: honour BlockLimits in bdrv_co_do_write_zeroes Peter Lieven
2013-10-20 15:43 ` [Qemu-devel] [PATCHv5 09/17] block: honour BlockLimits in bdrv_co_discard Peter Lieven
2013-10-20 15:43 ` [Qemu-devel] [PATCHv5 10/17] iscsi: simplify iscsi_co_discard Peter Lieven
2013-10-20 15:43 ` [Qemu-devel] [PATCHv5 11/17] iscsi: set limits in BlockDriverState Peter Lieven
2013-10-20 15:43 ` [Qemu-devel] [PATCHv5 12/17] iscsi: add bdrv_co_write_zeroes Peter Lieven
2013-10-20 15:43 ` [Qemu-devel] [PATCHv5 13/17] block: introduce bdrv_make_zero Peter Lieven
2013-10-20 15:43 ` [Qemu-devel] [PATCHv5 14/17] block/get_block_status: fix BDRV_BLOCK_ZERO for unallocated blocks Peter Lieven
2013-10-20 15:43 ` [Qemu-devel] [PATCHv5 15/17] qemu-img: add support for fully allocated images Peter Lieven
2013-10-20 15:43 ` [Qemu-devel] [PATCHv5 16/17] qemu-img: conditionally zero out target on convert Peter Lieven
2013-10-20 15:43 ` [Qemu-devel] [PATCHv5 17/17] block/raw: copy BlockLimits on raw_open Peter Lieven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1382283791-11181-6-git-send-email-pl@kamp.de \
    --to=pl@kamp.de \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=ronniesahlberg@gmail.com \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.