From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH] spi/s3c64xx: Fix doubled clock disable on suspend Date: Mon, 21 Oct 2013 13:41:59 +0200 Message-ID: <1382355719.8172.0.camel@AMDC1943> References: <1382348117-6666-1-git-send-email-k.kozlowski@samsung.com> <5264F709.2000409@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: Received: from mailout1.w1.samsung.com ([210.118.77.11]:63174 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752871Ab3JULmF (ORCPT ); Mon, 21 Oct 2013 07:42:05 -0400 In-reply-to: <5264F709.2000409@samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Sylwester Nawrocki Cc: Ben Dooks , Kukjin Kim , Mark Brown , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Kyungmin Park On Mon, 2013-10-21 at 11:42 +0200, Sylwester Nawrocki wrote: > pm_runtime_{get,put}* must not be called from drivers's system suspend/resume > callbacks. Please use pm_runtime_suspended() to check device runtime PM status > in s3c64xx_spi_{suspend,resume} callbacks and handle the clocks appropriately. Thanks for review, I will send fixed patch. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 From: k.kozlowski@samsung.com (Krzysztof Kozlowski) Date: Mon, 21 Oct 2013 13:41:59 +0200 Subject: [PATCH] spi/s3c64xx: Fix doubled clock disable on suspend In-Reply-To: <5264F709.2000409@samsung.com> References: <1382348117-6666-1-git-send-email-k.kozlowski@samsung.com> <5264F709.2000409@samsung.com> Message-ID: <1382355719.8172.0.camel@AMDC1943> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, 2013-10-21 at 11:42 +0200, Sylwester Nawrocki wrote: > pm_runtime_{get,put}* must not be called from drivers's system suspend/resume > callbacks. Please use pm_runtime_suspended() to check device runtime PM status > in s3c64xx_spi_{suspend,resume} callbacks and handle the clocks appropriately. Thanks for review, I will send fixed patch. Best regards, Krzysztof