From: Peng Tao <bergwolf@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, Peng Tao <bergwolf@gmail.com>,
Andreas Dilger <andreas.dilger@intel.com>
Subject: [PATCH 2/4] staging/lustre/llite: fix mkdir endless loop
Date: Mon, 21 Oct 2013 23:18:23 +0800 [thread overview]
Message-ID: <1382368705-4199-2-git-send-email-bergwolf@gmail.com> (raw)
In-Reply-To: <1382368705-4199-1-git-send-email-bergwolf@gmail.com>
Running on 3.11-rc4 kernel, I got below endless loop. It turns to be that Lustre
always saves the first page of a dir inode mapping at index ~0UL. And after
commit 5a720394 (mm: teach truncate_inode_pages_range() to handle non page
aligned ranges), truncate_inode_pages_range() _NO LONGER_ truncates the page
that is sitting at index ~0UL.
[16768.998006] mkdir R running task 0 2717 2716 0x00000080
[16768.998073] 000000000000000e 0000000000000000 0000000000000000 ffff88000be00460
[16768.998157] ffff88000ea65908 ffffffff810fec3e ffff88000ea65968 ffff8800229e7750
[16768.998241] ffff88000ea658b8 0000000000000000 0000000000000000 ffff88000ea65958
[16768.998326] Call Trace:
[16768.998401] [<ffffffff810fc6ed>] ? rcu_read_unlock+0x1c/0x2d
[16768.998473] [<ffffffff810fec3e>] ? find_get_pages+0xf5/0x11b
[16768.998530] [<ffffffff811078f0>] ? pagevec_lookup+0x20/0x2a
[16768.998586] [<ffffffff8110920e>] ? truncate_inode_pages_range.part.2+0x161/0x39a
[16768.998680] [<ffffffffa02ad5dc>] ? ll_md_blocking_ast+0x338/0x62f [lustre]
[16768.998744] [<ffffffff8110947f>] ? truncate_inode_pages_range+0x38/0x3f
[16768.998805] [<ffffffff811094f8>] ? truncate_inode_pages+0x12/0x14
[16768.998871] [<ffffffffa02ad6e8>] ? ll_md_blocking_ast+0x444/0x62f [lustre]
[16768.998948] [<ffffffff810981b5>] ? arch_local_irq_save+0x9/0xc
[16768.999022] [<ffffffffa07ee0e8>] ? ldlm_cancel_callback+0x67/0x12a [ptlrpc]
[16768.999100] [<ffffffffa07f85b2>] ? ldlm_cli_cancel_local+0xf3/0x2bc [ptlrpc]
[16768.999176] [<ffffffffa07f9163>] ? ldlm_cli_cancel_list_local+0x7e/0x1e4 [ptlrpc]
[16768.999268] [<ffffffffa07f9473>] ? ldlm_cancel_resource_local+0x1aa/0x1b9 [ptlrpc]
[16768.999385] [<ffffffffa0657bad>] ? mdc_resource_get_unused+0xf8/0x115 [mdc]
[16768.999472] [<ffffffff8109c887>] ? trace_hardirqs_on+0xd/0xf
[16768.999533] [<ffffffffa06583d8>] ? mdc_create+0x11e/0x4db [mdc]
[16768.999597] [<ffffffff8152ed84>] ? mutex_unlock+0xe/0x10
[16768.999654] [<ffffffffa0350e99>] ? lmv_create+0x355/0x3e9 [lmv]
[16768.999712] [<ffffffff811553b7>] ? final_putname+0x35/0x39
[16768.999775] [<ffffffffa02ae167>] ? ll_new_node+0x33b/0x3ff [lustre]
[16768.999841] [<ffffffffa02ae62c>] ? ll_mkdir+0xf2/0x127 [lustre]
[16768.999897] [<ffffffff81156996>] ? vfs_mkdir+0x84/0xc9
[16768.999961] [<ffffffff81158cf8>] ? SyS_mkdirat+0x77/0xad
[16769.000014] [<ffffffff81158d47>] ? SyS_mkdir+0x19/0x1b
[16769.000066] [<ffffffff81538652>] ? system_call_fastpath+0x16/0x1b
Signed-off-by: Peng Tao <bergwolf@gmail.com>
Signed-off-by: Andreas Dilger <andreas.dilger@intel.com>
---
.../staging/lustre/lustre/include/lustre_lite.h | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/include/lustre_lite.h b/drivers/staging/lustre/lustre/include/lustre_lite.h
index 25f8bfa..beccb5e 100644
--- a/drivers/staging/lustre/lustre/include/lustre_lite.h
+++ b/drivers/staging/lustre/lustre/include/lustre_lite.h
@@ -139,7 +139,11 @@ static inline unsigned long hash_x_index(__u64 hash, int hash64)
{
if (BITS_PER_LONG == 32 && hash64)
hash >>= 32;
- return ~0UL - hash;
+ /* save hash 0 as index 0 because otherwise we'll save it at
+ * page index end (~0UL) and it causes truncate_inode_pages_range()
+ * to loop forever.
+ */
+ return ~0UL - (hash + !hash);
}
/** @} lite */
--
1.7.9.5
next prev parent reply other threads:[~2013-10-21 15:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-21 15:18 [PATCH 1/4] lustre/fld: remove fld_thread_key Peng Tao
2013-10-21 15:18 ` Peng Tao [this message]
2013-10-21 15:18 ` [PATCH 3/4] staging/lustre: fix tv_usec build warning on parisc Peng Tao
2013-10-21 15:18 ` [PATCH 4/4] staging/lustre: fix coccinelle warnings Peng Tao
2013-10-27 3:15 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1382368705-4199-2-git-send-email-bergwolf@gmail.com \
--to=bergwolf@gmail.com \
--cc=andreas.dilger@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.