From: Steve Dickson <steved@redhat.com>
To: Linux NFS Mailing list <linux-nfs@vger.kernel.org>
Subject: [PATCH 2/3] mountd: Deprecate the ability to disable TCP listeners.
Date: Tue, 22 Oct 2013 04:19:25 -0400 [thread overview]
Message-ID: <1382429966-14531-3-git-send-email-steved@redhat.com> (raw)
In-Reply-To: <1382429966-14531-1-git-send-email-steved@redhat.com>
Disable the ability to turn off TCP listeners since that
is the protocol now required and best suited for
NFS traffic.
Signed-off-by: Steve Dickson <steved@redhat.com>
---
utils/mountd/mountd.c | 7 +++++--
utils/mountd/mountd.man | 3 ---
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/utils/mountd/mountd.c b/utils/mountd/mountd.c
index f918472..46ff05f 100644
--- a/utils/mountd/mountd.c
+++ b/utils/mountd/mountd.c
@@ -755,7 +755,10 @@ main(int argc, char **argv)
nfs_version &= ~NFSVERSBIT(vers);
break;
case 'n':
- NFSCTL_TCPUNSET(_rpcprotobits);
+ fprintf(stderr,
+ "Deprecated: The -n flag (the ability to disable TCP listeners)" \
+ " is no longer supported\n");
+ usage(progname, 1);
break;
case 'r':
reverse_resolve = 1;
@@ -905,7 +908,7 @@ usage(const char *prog, int n)
"Usage: %s [-F|--foreground] [-h|--help] [-v|--version] [-d kind|--debug kind]\n"
" [-o num|--descriptors num] [-f exports-file|--exports-file=file]\n"
" [-p|--port port] [-V version|--nfs-version version]\n"
-" [-N version|--no-nfs-version version] [-n|--no-tcp]\n"
+" [-N version|--no-nfs-version version] [-n|--no-tcp(deprecate)]\n"
" [-H ha-callout-prog] [-s|--state-directory-path path]\n"
" [-g|--manage-gids] [-t num|--num-threads=num]\n", prog);
exit(n);
diff --git a/utils/mountd/mountd.man b/utils/mountd/mountd.man
index b60dc90..c049e35 100644
--- a/utils/mountd/mountd.man
+++ b/utils/mountd/mountd.man
@@ -112,9 +112,6 @@ either one of these version should not be offered,
must be invoked with the option
.B "\-\-no-nfs-version <vers>" .
.TP
-.B \-n " or " \-\-no-tcp
-Don't advertise TCP for mount.
-.TP
.B \-P
Ignored (compatibility with unfsd??).
.TP
--
1.8.3.1
next prev parent reply other threads:[~2013-10-22 8:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-22 8:19 [PATCH 0/3] mountd: disabling turning off TCP listeners Steve Dickson
2013-10-22 8:19 ` [PATCH 1/3] mountd: Use protocol bit fields to turn protocols off Steve Dickson
2013-10-22 8:19 ` Steve Dickson [this message]
2013-10-22 11:39 ` [PATCH 2/3] mountd: Deprecate the ability to disable TCP listeners Jim Rees
2013-10-23 13:59 ` Steve Dickson
2013-10-23 14:42 ` Jim Rees
2013-10-22 8:19 ` [PATCH 3/3] mountd: Add the ability to disable UDP listeners Steve Dickson
-- strict thread matches above, loose matches on Subject: below --
2013-10-24 18:17 [PATCH 0/3] mountd: disabling turning off TCP listeners (v2) Steve Dickson
2013-10-24 18:17 ` [PATCH 2/3] mountd: Deprecate the ability to disable TCP listeners Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1382429966-14531-3-git-send-email-steved@redhat.com \
--to=steved@redhat.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.