From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ob0-x229.google.com ([2607:f8b0:4003:c01::229]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1VZB8l-00044f-RV for linux-mtd@lists.infradead.org; Thu, 24 Oct 2013 02:59:16 +0000 Received: by mail-ob0-f169.google.com with SMTP id uz6so1204080obc.0 for ; Wed, 23 Oct 2013 19:58:51 -0700 (PDT) From: Brian Norris To: Subject: [PATCH 2/5] mtd: m25p80: remove obsolete FIXME Date: Wed, 23 Oct 2013 19:58:20 -0700 Message-Id: <1382583503-13748-2-git-send-email-computersforpeace@gmail.com> In-Reply-To: <1382583503-13748-1-git-send-email-computersforpeace@gmail.com> References: <1382583503-13748-1-git-send-email-computersforpeace@gmail.com> Cc: Marek Vasut , sourav.poddar@ti.com, Brian Norris , Artem Bityutskiy List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , The FIXME and NOTE have already been fixed (we have FAST_READ support). Signed-off-by: Brian Norris --- drivers/mtd/devices/m25p80.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c index 63a95ac..7c4cbad 100644 --- a/drivers/mtd/devices/m25p80.c +++ b/drivers/mtd/devices/m25p80.c @@ -367,10 +367,6 @@ static int m25p80_read(struct mtd_info *mtd, loff_t from, size_t len, spi_message_init(&m); memset(t, 0, (sizeof t)); - /* NOTE: - * OPCODE_FAST_READ (if available) is faster. - * Should add 1 byte DUMMY_BYTE. - */ t[0].tx_buf = flash->command; t[0].len = m25p_cmdsz(flash) + (flash->fast_read ? 1 : 0); spi_message_add_tail(&t[0], &m); @@ -388,11 +384,6 @@ static int m25p80_read(struct mtd_info *mtd, loff_t from, size_t len, return 1; } - /* FIXME switch to OPCODE_FAST_READ. It's required for higher - * clocks; and at this writing, every chip this driver handles - * supports that opcode. - */ - /* Set up the write data buffer. */ opcode = flash->read_opcode; flash->command[0] = opcode; -- 1.8.4