All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Walker <dwalker@fifo99.com>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 2/3] fs: nfsd: remove calls to simple_strtoll
Date: Fri, 25 Oct 2013 19:33:12 -0700	[thread overview]
Message-ID: <1382754793-8827-2-git-send-email-dwalker@fifo99.com> (raw)

Signed-off-by: Daniel Walker <dwalker@fifo99.com>
---
 fs/nfsd/fault_inject.c | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/fs/nfsd/fault_inject.c b/fs/nfsd/fault_inject.c
index d620e7f..41165f0 100644
--- a/fs/nfsd/fault_inject.c
+++ b/fs/nfsd/fault_inject.c
@@ -125,20 +125,24 @@ static ssize_t fault_inject_write(struct file *file, const char __user *buf,
 	size_t size = min(sizeof(write_buf) - 1, len);
 	struct net *net = current->nsproxy->net_ns;
 	struct sockaddr_storage sa;
+	int ret = -EFAULT;
 	u64 val;
 
 	if (copy_from_user(write_buf, buf, size))
-		return -EFAULT;
+		return ret;
 	write_buf[size] = '\0';
 
 	size = rpc_pton(net, write_buf, size, (struct sockaddr *)&sa, sizeof(sa));
 	if (size > 0)
 		nfsd_inject_set_client(file_inode(file)->i_private, &sa, size);
 	else {
-		val = simple_strtoll(write_buf, NULL, 0);
-		nfsd_inject_set(file_inode(file)->i_private, val);
+		ret = kstrtoll(write_buf, 0, &val);
+		if (ret == 0) {
+			nfsd_inject_set(file_inode(file)->i_private, val);
+			ret = len;
+		}
 	}
-	return len; /* on success, claim we got the whole input */
+	return ret; /* on success, claim we got the whole input */
 }
 
 static const struct file_operations fops_nfsd = {
-- 
1.8.3.2


             reply	other threads:[~2013-10-26  2:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-26  2:33 Daniel Walker [this message]
2013-10-26 18:41 ` [PATCH 2/3] fs: nfsd: remove calls to simple_strtoll J. Bruce Fields
2013-10-27 15:09   ` Daniel Walker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1382754793-8827-2-git-send-email-dwalker@fifo99.com \
    --to=dwalker@fifo99.com \
    --cc=bfields@fieldses.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.