All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paulo Zanoni <przanoni@gmail.com>
To: intel-gfx@lists.freedesktop.org
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
Subject: [PATCH 3/3] drm/i915: cancel the panel VDD work when we do it manually
Date: Wed, 30 Oct 2013 19:50:28 -0200	[thread overview]
Message-ID: <1383169828-1589-3-git-send-email-przanoni@gmail.com> (raw)
In-Reply-To: <1383169828-1589-1-git-send-email-przanoni@gmail.com>

From: Paulo Zanoni <paulo.r.zanoni@intel.com>

After I reorganized the panel VDD debug messages I was able to spot we
were disabling it one extra time. The problem is that we're missing
the call to cancel the delayed work in one of the instances where we
manually call ironlake_panel_vdd_off_sync().

Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
---
 drivers/gpu/drm/i915/intel_dp.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index 8db1fda..f2280b4 100644
--- a/drivers/gpu/drm/i915/intel_dp.c
+++ b/drivers/gpu/drm/i915/intel_dp.c
@@ -1159,6 +1159,7 @@ void ironlake_edp_panel_vdd_off(struct intel_dp *intel_dp, bool sync)
 	intel_dp->want_panel_vdd = false;
 
 	if (sync) {
+		cancel_delayed_work_sync(&intel_dp->panel_vdd_work);
 		ironlake_panel_vdd_off_sync(intel_dp);
 	} else {
 		/*
-- 
1.8.3.1

  parent reply	other threads:[~2013-10-30 21:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-30 21:50 [PATCH 1/3] drm/i915: turn the eDP VDD on for any i2c transactions Paulo Zanoni
2013-10-30 21:50 ` [PATCH 2/3] drm/i915: reduce eDP VDD message verbose Paulo Zanoni
2013-10-30 21:50 ` Paulo Zanoni [this message]
2013-10-31 11:11   ` [PATCH 3/3] drm/i915: cancel the panel VDD work when we do it manually Daniel Vetter
2013-10-31 12:46     ` Jani Nikula
2013-10-31 13:15       ` Paulo Zanoni
2013-10-31 14:13       ` Daniel Vetter
2013-10-31  8:14 ` [PATCH 1/3] drm/i915: turn the eDP VDD on for any i2c transactions Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1383169828-1589-3-git-send-email-przanoni@gmail.com \
    --to=przanoni@gmail.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=paulo.r.zanoni@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.