From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Janis Coders <janis.coders@gmail.com>
Cc: OpenEmbedded Core Mailing List
<openembedded-core@lists.openembedded.org>
Subject: Re: Patch file search order in DORA (1.5)
Date: Fri, 01 Nov 2013 14:36:11 +0000 [thread overview]
Message-ID: <1383316571.6271.33.camel@ted> (raw)
In-Reply-To: <5273B339.6090700@gmail.com>
On Fri, 2013-11-01 at 15:57 +0200, Janis Coders wrote:
> Hi, I am working on Freescale's BSP with my custom layer which overrides
> (appends) the Linux kernel's recipe.
> In version 1.4 my custom recipe's defconfig had priority over the
> 'original' layer's defconfig, but in 1.5 the priority has
> changed. After some debugging I found out that seems like order of patch
> file searching has changed in version 1.5.
>
> Order in 1.4 (example):
> DEBUG: Searching for defconfig in paths:
> /home/chocis/projects/balticembedded-bsp/sources/meta-balticembedded/recipes-balticembedded/linux/linux-imx/arm
> /home/chocis/projects/balticembedded-bsp/sources/meta-balticembedded/recipes-balticembedded/linux/linux-imx/armv7a
> /home/chocis/projects/balticembedded-bsp/sources/meta-balticembedded/recipes-balticembedded/linux/linux-imx/mx5
> /home/chocis/projects/balticembedded-bsp/sources/meta-balticembedded/recipes-balticembedded/linux/linux-imx/mx53
> /home/chocis/projects/balticembedded-bsp/sources/meta-balticembedded/recipes-balticembedded/linux/linux-imx/imx53be
> /home/chocis/projects/balticembedded-bsp/sources/meta-balticembedded/recipes-balticembedded/linux/linux-imx/poky
> /home/chocis/projects/balticembedded-bsp/sources/meta-balticembedded/recipes-balticembedded/linux/linux-imx/
> /home/chocis/projects/balticembedded-bsp/sources/meta-fsl-arm/recipes-kernel/linux/linux-imx-2.6.35.3/arm
> /home/chocis/projects/balticembedded-bsp/sources/meta-fsl-arm/recipes-kernel/linux/linux-imx-2.6.35.3/armv7a
> /home/chocis/projects/balticembedded-bsp/sources/meta-fsl-arm/recipes-kernel/linux/linux-imx-2.6.35.3/mx5
>
> ......
> Order in 1.5 (example):
> /home/chocis/projects/testdorafreescale/sources/meta-balticembedded/recipes-balticembedded/linux/linux-imx/poky
> /home/chocis/projects/testdorafreescale/sources/meta-fsl-arm-extra/recipes-kernel/linux/linux-imx-2.6.35.3/poky
> /home/chocis/projects/testdorafreescale/sources/meta-fsl-arm/recipes-kernel/linux/linux-imx-2.6.35.3/poky
> /home/chocis/projects/testdorafreescale/sources/meta-fsl-arm/recipes-kernel/linux/linux-imx/poky
> /home/chocis/projects/testdorafreescale/sources/meta-fsl-arm/recipes-kernel/linux/files/poky
> /home/chocis/projects/testdorafreescale/sources/meta-balticembedded/recipes-balticembedded/linux/linux-imx/imx53be
> /home/chocis/projects/testdorafreescale/sources/meta-fsl-arm-extra/recipes-kernel/linux/linux-imx-2.6.35.3/imx53be
> /home/chocis/projects/testdorafreescale/sources/meta-fsl-arm/recipes-kernel/linux/linux-imx-2.6.35.3/imx53be
> /home/chocis/projects/testdorafreescale/sources/meta-fsl-arm/recipes-kernel/linux/linux-imx/imx53be
> /home/chocis/projects/testdorafreescale/sources/meta-fsl-arm/recipes-kernel/linux/files/imx53be
> .........
>
> Was this intended and specially changed in version 1.5? Because now I
> have to move my defconfig one directory deeper
> to get the priority.
It was not in the 1.5 release however I have just realised it is in the
dora branch and it is a change of behaviour there. I'm not sure it was
intentionally included for 1.5.1 and that is something we need to
discuss.
http://git.yoctoproject.org/cgit.cgi/poky/commit/?h=dora&id=0bd63125c3b44a656e44f2a76cc5f832c9db4bbd
I would say that the change is in master and is intentional however and
if you look at the search order, it does make more sense this way
around. Any distro override file should come first, then say armv7, then
armv6 and so on. In the original order, arm overrides armv7 which
overrides machine specific which makes no sense.
On those grounds it is a valid bug fix for 1.5.1 IMO.
Cheers,
Richard
next prev parent reply other threads:[~2013-11-01 14:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-01 13:57 Patch file search order in DORA (1.5) Janis Coders
2013-11-01 14:36 ` Richard Purdie [this message]
2013-11-01 15:38 ` Otavio Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1383316571.6271.33.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=janis.coders@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.