All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Martin Jansa <martin.jansa@gmail.com>
Cc: openembedded-commits@lists.openembedded.org,
	openembedded-core@lists.openembedded.org
Subject: Re: [oe-commits] Richard Purdie : gcc: Fix strange C++ repo issues
Date: Mon, 04 Nov 2013 14:42:52 +0000	[thread overview]
Message-ID: <1383576172.6271.138.camel@ted> (raw)
In-Reply-To: <20131104130253.GD3684@jama>

On Mon, 2013-11-04 at 14:02 +0100, Martin Jansa wrote:
> On Mon, Oct 14, 2013 at 03:45:35PM +0000, git@git.openembedded.org wrote:
> > Module: openembedded-core.git
> > Branch: master
> > Commit: 9f6c4edf40963d1f3fb9f7e2d2b7a866aa1afe57
> > URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=9f6c4edf40963d1f3fb9f7e2d2b7a866aa1afe57
> > 
> > Author: Richard Purdie <richard.purdie@linuxfoundation.org>
> > Date:   Wed Oct  9 20:37:49 2013 +0000
> > 
> > gcc: Fix strange C++ repo issues
> > 
> > Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> > 
> > ---
> > 
> >  meta/recipes-devtools/gcc/gcc-4.8.inc              |    1 +
> >  .../gcc/gcc-4.8/0047-repomembug.patch              |   53 ++++++++++++++++++++
> >  2 files changed, 54 insertions(+), 0 deletions(-)
> > 
> > diff --git a/meta/recipes-devtools/gcc/gcc-4.8.inc b/meta/recipes-devtools/gcc/gcc-4.8.inc
> > index 4af98f8..8d50bf7 100644
> > --- a/meta/recipes-devtools/gcc/gcc-4.8.inc
> > +++ b/meta/recipes-devtools/gcc/gcc-4.8.inc
> > @@ -76,6 +76,7 @@ SRC_URI = "${GNU_MIRROR}/gcc/gcc-${PV}/gcc-${PV}.tar.bz2 \
> >  	   file://0044-gengtypes.patch \
> >  	   file://0045-gcc-4.8-PR57717-PowerPC-E500v2.patch \
> >  	   file://0046-libatomic-deptracking.patch \
> > +	   file://0047-repomembug.patch \
> >  	  "
> 
> Don't mix tabs and spaces in multiline variables.
> 
> All tabs in meta/recipes-devtools/gcc/gcc-4.8.inc are used incorrectly.

Agreed, however I just copied the existing style which was better than
the alternatives. Whitespace changes need to be in a separate patch.

Cheers,

Richard



      reply	other threads:[~2013-11-04 14:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20131014154535.D40A750398@opal>
2013-11-04 13:02 ` [oe-commits] Richard Purdie : gcc: Fix strange C++ repo issues Martin Jansa
2013-11-04 14:42   ` Richard Purdie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1383576172.6271.138.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=martin.jansa@gmail.com \
    --cc=openembedded-commits@lists.openembedded.org \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.