From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH RESEND 07/12] xen: numa-sched: use per-vcpu
 node-affinity for actual scheduling
Date: Wed, 6 Nov 2013 10:15:29 +0100
Message-ID: <1383729329.9207.74.camel@Solace>
References: <20131105142844.30446.78671.stgit@Solace>
	<20131105143519.30446.9826.stgit@Solace>
	<52791AE0.2000102@eu.citrix.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7090515527132265817=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <52791AE0.2000102@eu.citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: George Dunlap <george.dunlap@eu.citrix.com>
Cc: Marcus Granado <Marcus.Granado@eu.citrix.com>, Keir Fraser <keir@xen.org>, Ian Campbell <Ian.Campbell@citrix.com>, Li Yechen <lccycc123@gmail.com>, Andrew Cooper <Andrew.Cooper3@citrix.com>, Juergen Gross <juergen.gross@ts.fujitsu.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>, xen-devel@lists.xen.org, Jan Beulich <JBeulich@suse.com>, Justin Weaver <jtweaver@hawaii.edu>, Daniel De Graaf <dgdegra@tycho.nsa.gov>, Matt Wilson <msw@amazon.com>, Elena Ufimtseva <ufimtseva@gmail.com>
List-Id: xen-devel@lists.xenproject.org

--===============7090515527132265817==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-rtZm02Og/ucD6KLTv5nt"

--=-rtZm02Og/ucD6KLTv5nt
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On mar, 2013-11-05 at 16:20 +0000, George Dunlap wrote:
> On 11/05/2013 02:35 PM, Dario Faggioli wrote:

> > @@ -308,11 +279,9 @@ static void csched_set_node_affinity(
> >   static inline int __vcpu_has_node_affinity(const struct vcpu *vc,
> >                                              const cpumask_t *mask)
> >   {
> > -    const struct domain *d =3D vc->domain;
> > -    const struct csched_dom *sdom =3D CSCHED_DOM(d);
> > -
> > -    if (cpumask_full(sdom->node_affinity_cpumask)
> > -         || !cpumask_intersects(sdom->node_affinity_cpumask, mask) )
> > +    if ( vc->auto_node_affinity =3D=3D 1
> > +         || cpumask_full(vc->node_affinity)
> > +         || !cpumask_intersects(vc->node_affinity, mask) )
>=20
> Isn't cpumask_full(vc->node_affinity) <=3D> vc->auto_node_affinity at thi=
s=20
> point?
>=20
It is. I'd be killing the cpumask_full() part, if it wasn't for the fact
that we decided to re-architect all the thing, and I'm doing the latter
right now.

> Other than that, I think this whole patch looks good -- nice when you=20
> can add a feature and simplify the code. :-)
>=20
Nice indeed! :-)

Thanks and Regards,
Dario

--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


--=-rtZm02Og/ucD6KLTv5nt
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.15 (GNU/Linux)

iEYEABECAAYFAlJ6CLEACgkQk4XaBE3IOsS4FwCdHWtknZB305mkzeiJ94Y9jmLg
WcwAn3HjrTwr4qfEA0bVlMtQ4gEvsX4C
=Q+4Y
-----END PGP SIGNATURE-----

--=-rtZm02Og/ucD6KLTv5nt--


--===============7090515527132265817==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============7090515527132265817==--