From: Giuseppe Pagano <giuseppe.pagano@seco.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/4] udoo: Add SATA disk support.
Date: Thu, 07 Nov 2013 13:41:45 +0100 [thread overview]
Message-ID: <1383828105.3371.94.camel@localhost> (raw)
In-Reply-To: <527B5206.4080001@denx.de>
On Thu, 2013-11-07 at 09:40 +0100, Stefano Babic wrote:
> Hi Giuseppe,
>
> On 06/11/2013 21:37, Giuseppe Pagano wrote:
> > Add Sata support on uDoo Board.
> >
> > Signed-off-by: Giuseppe Pagano <giuseppe.pagano@seco.com>
> > Cc: sbabic at denx.de
> >
> > ---
....
> > +#ifdef CONFIG_CMD_SATA
> > +int setup_sata(void)
> > +{
> > + struct iomuxc_base_regs *const iomuxc_regs
> > + = (struct iomuxc_base_regs *)IOMUXC_BASE_ADDR;
> > +
> > + int ret = enable_sata_clock();
> > + if (ret)
> > + return ret;
> > +
> > + clrsetbits_le32(&iomuxc_regs->gpr[13],
> > + IOMUXC_GPR13_SATA_MASK,
> > + IOMUXC_GPR13_SATA_PHY_8_RXEQ_3P0DB
> > + |IOMUXC_GPR13_SATA_PHY_7_SATA2M
> > + |IOMUXC_GPR13_SATA_SPEED_3G
> > + |(3<<IOMUXC_GPR13_SATA_PHY_6_SHIFT)
> > + |IOMUXC_GPR13_SATA_SATA_PHY_5_SS_DISABLED
> > + |IOMUXC_GPR13_SATA_SATA_PHY_4_ATTEN_9_16
> > + |IOMUXC_GPR13_SATA_PHY_3_TXBOOST_0P00_DB
> > + |IOMUXC_GPR13_SATA_PHY_2_TX_1P104V
> > + |IOMUXC_GPR13_SATA_PHY_1_SLOW);
> > +
> > + return 0;
> > +}
> > +#endif
>
> Do not copy code ! If you want to reuse functions from nitrogen, please
> factorize the function and put it into imx-common, thanks.
Ok, I'll do.
I'm going to produce a new udoo patch with git send-patch and I'll
submit as v2 of this one.
> Best regards,
> Stefano Babic
Best regards,
Giuseppe Pagano
prev parent reply other threads:[~2013-11-07 12:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-06 20:37 [U-Boot] [PATCH 2/4] udoo: Add SATA disk support Giuseppe Pagano
2013-11-07 8:40 ` Stefano Babic
2013-11-07 12:41 ` Giuseppe Pagano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1383828105.3371.94.camel@localhost \
--to=giuseppe.pagano@seco.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.