From: Ravi kumar Veeramally <ravikumar.veeramally@linux.intel.com>
To: linux-bluetooth@vger.kernel.org
Cc: Ravi kumar Veeramally <ravikumar.veeramally@linux.intel.com>
Subject: [PATCH_v3 2/5] android/hid: Fix set report data format in daemon
Date: Fri, 8 Nov 2013 12:24:28 +0200 [thread overview]
Message-ID: <1383906271-23554-3-git-send-email-ravikumar.veeramally@linux.intel.com> (raw)
In-Reply-To: <1383906271-23554-1-git-send-email-ravikumar.veeramally@linux.intel.com>
Report data coming to HAL is in ascii format, HAL sends
data in hex to daemon, so convert to binary.
---
android/hidhost.c | 16 +++++++++++++---
1 file changed, 13 insertions(+), 3 deletions(-)
diff --git a/android/hidhost.c b/android/hidhost.c
index c7b4114..9b4bb15 100644
--- a/android/hidhost.c
+++ b/android/hidhost.c
@@ -98,6 +98,14 @@ struct hid_device {
uint8_t last_hid_msg;
};
+static void hex2bin(const uint8_t *ascii, int ascii_len, uint8_t *hex)
+{
+ int i;
+
+ for (i = 0; i < ascii_len / 2; i++)
+ sscanf((char *) &ascii[i * 2], "%hhx", &hex[i]);
+}
+
static int device_cmp(gconstpointer s, gconstpointer user_data)
{
const struct hid_device *dev = s;
@@ -900,18 +908,20 @@ static uint8_t bt_hid_set_report(struct hal_cmd_hidhost_set_report *cmd,
return HAL_STATUS_FAILED;
dev = l->data;
- req_size = 1 + cmd->len;
+ /* Report data coming to HAL is in ascii format, HAL sends
+ * data in hex to daemon, so convert to binary. */
+ req_size = 1 + (cmd->len / 2);
req = g_try_malloc0(req_size);
if (!req)
return HAL_STATUS_NOMEM;
req[0] = HID_MSG_SET_REPORT | cmd->type;
- memcpy(req + 1, cmd->data, req_size - 1);
+ hex2bin(cmd->data, cmd->len, (req + 1));
fd = g_io_channel_unix_get_fd(dev->ctrl_io);
if (write(fd, req, req_size) < 0) {
- error("error while querying device protocol");
+ error("error while sending report");
g_free(req);
return HAL_STATUS_FAILED;
}
--
1.8.3.2
next prev parent reply other threads:[~2013-11-08 10:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-08 10:24 [PATCH_v3 0/5] Fixed and implemented set report and send data ifaces Ravi kumar Veeramally
2013-11-08 10:24 ` [PATCH_v3 1/5] android/hid: Fix set seport ipc cmd preparation Ravi kumar Veeramally
2013-11-08 11:07 ` Johan Hedberg
2013-11-08 11:28 ` Ravi Kumar Veeramally
2013-11-08 10:24 ` Ravi kumar Veeramally [this message]
2013-11-08 11:05 ` [PATCH_v3 2/5] android/hid: Fix set report data format in daemon Johan Hedberg
2013-11-08 11:26 ` Ravi Kumar Veeramally
2013-11-08 10:24 ` [PATCH_v3 3/5] android/hid: Fill send data command struct in hal-hidhost Ravi kumar Veeramally
2013-11-08 10:24 ` [PATCH_v3 4/5] android/hid: Add send data implemention in daemon Ravi kumar Veeramally
2013-11-08 10:24 ` [PATCH_v3 5/5] android/hid: Add virtual unplug " Ravi kumar Veeramally
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1383906271-23554-3-git-send-email-ravikumar.veeramally@linux.intel.com \
--to=ravikumar.veeramally@linux.intel.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.