All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andreas Werner <wernerandy@gmx.de>
To: wsa@the-dreams.de
Cc: jacmet@sunsite.dk, marex@denx.de, baohua.song@csr.com,
	linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
	wernerandy@gmx.de
Subject: [PATCH] I2C: busses: Do not print error message in syslog if no ACK received
Date: Tue, 12 Nov 2013 18:45:36 +0100	[thread overview]
Message-ID: <1384278336-3694-1-git-send-email-wernerandy@gmx.de> (raw)

Using the i2c-eg20t driver and call i2cdetect or probe on the bus,
the driver will print a lot of error messages if there was no ACK
received.

i2cdetect normally print a table with all the available devices. If there
is no device on the address, the table will be empty.
Currently with the i2c-eg20t driver, the table is not visible because
the error messages destroy the table.

Error message: pch_i2c_getack return -71

This patch prevent the driver to print the messages to syslog if debug is not set.

Tested on Intel Atom E6xx and Eg20t Chipset.

Signed-off-by: Andreas Werner <wernerandy@gmx.de>
---
 drivers/i2c/busses/i2c-eg20t.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i2c/busses/i2c-eg20t.c b/drivers/i2c/busses/i2c-eg20t.c
index 0f37529..b10c651 100644
--- a/drivers/i2c/busses/i2c-eg20t.c
+++ b/drivers/i2c/busses/i2c-eg20t.c
@@ -322,7 +322,7 @@ static s32 pch_i2c_getack(struct i2c_algo_pch_data *adap)
 	reg_val = ioread32(p + PCH_I2CSR) & PCH_GETACK;
 
 	if (reg_val != 0) {
-		pch_err(adap, "return%d\n", -EPROTO);
+		pch_dbg(adap, "return%d\n", -EPROTO);
 		return -EPROTO;
 	}
 
-- 
1.8.4

             reply	other threads:[~2013-11-12 17:45 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-12 17:45 Andreas Werner [this message]
2013-11-12 18:00 ` [PATCH] I2C: busses: Do not print error message in syslog if no ACK received Marek Vasut
     [not found]   ` <201311121900.59305.marex-ynQEQJNshbs@public.gmane.org>
2013-11-12 18:23     ` Andreas Werner
2013-11-12 18:23       ` Andreas Werner
     [not found]       ` <20131112182344.GA5012-Zv899e0YUSYXU02nzanrWNbf9cGiqdzd@public.gmane.org>
2013-11-12 18:33         ` Marek Vasut
2013-11-12 18:33           ` Marek Vasut
     [not found]           ` <201311121933.41038.marex-ynQEQJNshbs@public.gmane.org>
2013-11-13 18:24             ` Andreas Werner
2013-11-13 18:24               ` Andreas Werner
     [not found]               ` <20131113182415.GA1458-Zv899e0YUSYXU02nzanrWNbf9cGiqdzd@public.gmane.org>
2013-11-13 19:24                 ` Marek Vasut
2013-11-13 19:24                   ` Marek Vasut
     [not found]                   ` <201311132024.06853.marex-ynQEQJNshbs@public.gmane.org>
2013-11-14 13:39                     ` Joe Perches
2013-11-14 13:39                       ` Joe Perches
2013-11-14 18:26                       ` Andreas Werner
2013-11-14 18:26                         ` Andreas Werner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1384278336-3694-1-git-send-email-wernerandy@gmx.de \
    --to=wernerandy@gmx.de \
    --cc=baohua.song@csr.com \
    --cc=jacmet@sunsite.dk \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marex@denx.de \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.