All of lore.kernel.org
 help / color / mirror / Atom feed
From: jeff.mcgee@intel.com
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH] drm/i915: Update rps interrupt limits
Date: Tue, 12 Nov 2013 14:32:10 -0600	[thread overview]
Message-ID: <1384288331-303-1-git-send-email-jeff.mcgee@intel.com> (raw)

From: Jeff McGee <jeff.mcgee@intel.com>

This bug was found on OTC Haswell Android product which makes use of
sysfs to set rps min and max range at boot.

This patch follows the original patch in implementing the fix with
a minimum of code change, which was desirable for late
stage product. A cleaner fix might involve refactoring the rps
interface a bit by perhaps making gen6_rps_limits a public function
that could be called from debugfs with the desired min/max. And the
register update could be placed in that function. Let me know if
something like that is more desirable for upstream and provide any
thoughts on form.

I also noticed that writing the interrupt limits register has been
removed for Valleyview recently by Chris Wilson, so I have removed
those parts of the original patch. I guess that means that it is
not relevant for Valleyview?

Jeff McGee (1):
  drm/i915: Update rps interrupt limits

 drivers/gpu/drm/i915/i915_sysfs.c | 10 ++++++++++
 drivers/gpu/drm/i915/intel_pm.c   | 10 +++++++++-
 2 files changed, 19 insertions(+), 1 deletion(-)

-- 
1.8.4.2

             reply	other threads:[~2013-11-12 20:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-12 20:32 jeff.mcgee [this message]
2013-11-12 20:32 ` [PATCH] drm/i915: Update rps interrupt limits jeff.mcgee
2013-11-12 21:04   ` [PATCH v2] " jeff.mcgee
2013-11-13 19:09     ` Daniel Vetter
2014-02-04 17:37       ` [PATCH v3] " jeff.mcgee
2014-02-07  9:26         ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1384288331-303-1-git-send-email-jeff.mcgee@intel.com \
    --to=jeff.mcgee@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.