Re: [PATCH RESEND 09/12] libxc: numa-sched: enable getting/specifying per-vcpu node-affinity

[Dario Faggioli <dario.faggioli@citrix.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1804 bytes --]

On mar, 2013-11-12 at 14:13 -0500, Konrad Rzeszutek Wilk wrote:
> On Tue, Nov 12, 2013 at 07:40:24PM +0100, Dario Faggioli wrote:
> > Mmm... As George said already, that is the most common behavior in
> > libxc... If we want something different, we should really write it down
> > somewhere (or has that happened already and I'm missing it?).
> 
> I was under the impression that was it - but I am probably misremembering
> Ian's comments and now sowing disinformation.
> 
Well, it may well have been me having missed that, so, really, no big
deal at all. :-)

> > > > +    set_xen_guest_handle(domctl.u.vcpuaffinity.map.bitmap, local);
> > > > +    domctl.u.vcpuaffinity.map.nr_bits = nodesize * 8;
> > > 
> > > Could the 8 be replaced by a sizeof?
> > >
> > I guess it could... What was it that you had in mind in particular?
> > 
> > Personally, I consider the names 'bitmap' and 'nr_bits' talking enough
> > to feel comfortable with the 8... To the point that I think the
> > following would be even less readable:
> > 
> >  domctl.u.vcpuaffinity.map.nr_bits = nodesize * 
> >         sizeof(domctl.u.vcpuaffinity.cpumap.bitmap);
> 
> Eww. That is worst. Somehow I assumed you could just do 'sizeof(unsigned long long)'
> or such. or some #define for this magic number.
>
Maybe I can... I'll look into that (although no promises, ok? :-P). This
is all about playing games with uint8_t and array of them with weird
sizes... Again, I'll see if I can come up with something...

Thanks and Regards,
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel