From: Chris Boot <bootc@bootc.net>
To: netfilter-devel@vger.kernel.org
Cc: Chris Boot <bootc@bootc.net>
Subject: [PATCH] ulogd: ulogd_inppkt_NFLOG: close nflog handle after unbinding
Date: Mon, 18 Nov 2013 11:09:14 +0000 [thread overview]
Message-ID: <1384772954-20144-1-git-send-email-bootc@bootc.net> (raw)
The nflog handle is closed, and then nflog_unbind_pf() is called on it, which
triggers an assertion failure within libnfnetlink. This patch simply moves
the nflog_close() just after the nflog_unbind_pf() calls.
Signed-off-by: Chris Boot <bootc@bootc.net>
---
The below information is included in the Debian patch file (Debian's DEP-3
patch tagging guidelines):
Author: Chris Boot <debian@bootc.net>
Bug: https://bugzilla.netfilter.org/show_bug.cgi?id=871
Bug-Debian: http://bugs.debian.org/729055
Bug-Ubuntu: https://bugs.launchpad.net/bugs/1250520
Forwarded: https://bugzilla.netfilter.org/attachment.cgi?id=425
Last-Update: 2013-11-15
Regards,
Chris
--- ulogd2-2.0.2.orig/input/packet/ulogd_inppkt_NFLOG.c
+++ ulogd2-2.0.2/input/packet/ulogd_inppkt_NFLOG.c
@@ -618,12 +618,12 @@ static int start(struct ulogd_pluginstan
return 0;
out_bind:
- nflog_close(ui->nful_h);
if (group_ce(upi->config_kset).u.value == 0) {
nflog_unbind_pf(ui->nful_h, AF_INET);
nflog_unbind_pf(ui->nful_h, AF_INET6);
nflog_unbind_pf(ui->nful_h, AF_BRIDGE);
}
+ nflog_close(ui->nful_h);
out_handle:
free(ui->nfulog_buf);
out_buf:
next reply other threads:[~2013-11-18 11:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-18 11:09 Chris Boot [this message]
2013-11-18 22:32 ` [PATCH] ulogd: ulogd_inppkt_NFLOG: close nflog handle after unbinding Eric Leblond
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1384772954-20144-1-git-send-email-bootc@bootc.net \
--to=bootc@bootc.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.