Re: [PATCH 1/7] allarch: Always inhibit default dependencies and set empty TARGET_PREFIX

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Sun, 2013-11-17 at 14:52 +0100, Martin Jansa wrote:
> * typical case where we inherit allarch and override PACKAGE_ARCH
>   are packagegroup recipes, but those need default dependencies
>   inhibited even when they are MACHINE_ARCH or TUNE_PKGARCH.
>   I don't know about any recipe which inherits allarch and needs
>   default dependencies.

The code there was added to allow the allarch class to be enabled or
disabled. I don't remember exactly why we needed to do that however it
was added for a reason and making part of it unconditional again will
probably break whyever we made it optional :(.

I can understand how you came to this conclusion though. Which cases is
this causing problems for?

> * set empty TARGET_PREFIX
>   This has a bit weird reason caused by unsupported setup where
>   external-toolchain is used in some DISTRO only for some MACHINEs
>   and internal is used for other MACHINEs.
>   Because external-toolchain usually comes with different TARGET_PREFIX
>   it was causing allarch recipes to have different signatures even
>   when they don't use toolchain at all.
>   Empty TARGET_PREFIX also helps to find allarch recipes which still
>   have default dependency on e.g. virtual/${TARGET_PREFIX}gcc.

This seems ok, I'd have taken it if it was a separate patch.

Cheers,

Richard